Skip to content

Fix OpenMP resource cleanup #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
allnes merged 6 commits into from
Jun 24, 2025
Merged

Fix OpenMP resource cleanup #479

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
710dcf6
Move OpenMP cleanup to base Task destructor
aobolensk Jun 24, 2025
2b0d2a2
Clean up OpenMP include guards
aobolensk Jun 24, 2025
708a6b8
Move OpenMP cleanup out of compile guards
aobolensk Jun 24, 2025
484beda
clang-format
aobolensk Jun 24, 2025
184673f
soft
aobolensk Jun 24, 2025
c684e9b
only omp 5.0
aobolensk Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions modules/core/task/include/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,9 @@
#include <iomanip>
#include <iostream>
#include <memory>
#ifdef _OPENMP
#include <omp.h>
#endif
#include <sstream>
#include <stdexcept>
#include <string>
Expand Down Expand Up @@ -177,6 +180,9 @@ class Task {
} else {
functions_order_.clear();
}
#ifdef _OPENMP
Copy link
Copy Markdown
Member

@allnes allnes Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we use define, is it no base function of omp library?

Copy link
Copy Markdown
Member Author

@aobolensk aobolensk Jun 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need. Removed

omp_pause_resource_all(omp_pause_hard);
#endif
}

protected:
Expand Down
1 change: 1 addition & 0 deletions tasks/example_threads/omp/src/ops_omp.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
#include <atomic>
#include <numeric>
#include <vector>
#include <omp.h>

#include "core/util/include/util.hpp"
#include "example_threads/common/include/common.hpp"
Expand Down