Merged
Conversation
allnes
reviewed
Jun 24, 2025
| } else { | ||
| functions_order_.clear(); | ||
| } | ||
| #ifdef _OPENMP |
Member
There was a problem hiding this comment.
Why we use define, is it no base function of omp library?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #479 +/- ##
=======================================
Coverage 91.73% 91.73%
=======================================
Files 11 11
Lines 363 363
Branches 131 131
=======================================
Hits 333 333
Misses 10 10
Partials 20 20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
allnes
approved these changes
Jun 24, 2025
Member
|
I think before merging this PR we need to increase version of msvc openmp |
Member
Author
I guess we can guard it with macro, as I have done just now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.