Refactoring for new API#388
Merged
allnes merged 25 commits intolearning-process:masterfrom May 16, 2025
Merged
Conversation
Member
Author
github-actions
Bot
added
task:mpi
task:omp
task:tbb
task:seq
task:stl
infrastructure
core
task:all
samples
labels
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 93.49% 97.70% +4.21%
==========================================
Files 26 16 -10
Lines 507 261 -246
Branches 149 84 -65
==========================================
- Hits 474 255 -219
+ Misses 18 2 -16
+ Partials 15 4 -11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
@aobolensk PR is ready |
Member
Author
|
@aobolensk I tried to increase coverage because new refactor critically deacreased it, and I simplified check order of functions that why please check new algo and I think this pr is not relevant. |
aobolensk
requested changes
May 16, 2025
Comment on lines
+4
to
+6
| // NOLINTNEXTLINE | ||
| #define INSTANTIATE_TEST_SUITE_P_NOLINT(prefix, test_case_name, generator) \ | ||
| INSTANTIATE_TEST_SUITE_P(prefix, test_case_name, generator) // NOLINT |
Member
There was a problem hiding this comment.
I'm not sure that it is necessary to mark it twice.
I guess it is better to wrap /* NOLINTBEGIN / ... / NOLINTEND */
aobolensk
approved these changes
May 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.