Skip to content

Commit d7a65b0

Browse files
allnesallnes
committed
fix clang tidy
1 parent cb553bf commit d7a65b0

13 files changed

Lines changed: 33 additions & 36 deletions

File tree

‎modules/core/util/include/util.hpp‎

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,9 @@
11
#pragma once
22
#include <string>
33

4+
#define INSTANTIATE_TEST_SUITE_P_NOLINT(prefix, test_case_name, generator) \
5+
INSTANTIATE_TEST_SUITE_P(prefix, test_case_name, generator) // NOLINT
6+
47
namespace ppc::util {
58

69
std::string GetAbsolutePath(const std::string &relative_path);

‎tasks/all/example/func_tests/main.cpp‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,11 @@
11
#include <gtest/gtest.h>
22

3-
#include <cstddef>
43
#include <cstdint>
5-
#include <memory>
64
#include <stb_library.hpp>
75
#include <string>
86
#include <vector>
97

108
#include "all/example/include/ops_all.hpp"
11-
#include "core/task/include/task.hpp"
129
#include "core/util/include/util.hpp"
1310

1411
class NesterovATestTaskAll : public ::testing::TestWithParam<int> {
@@ -46,4 +43,4 @@ TEST_P(NesterovATestTaskAll, MatmulFromPic) {
4643
EXPECT_EQ(in, test_task_all.Get());
4744
}
4845

49-
INSTANTIATE_TEST_SUITE_P(PicMatrixTests, NesterovATestTaskAll, ::testing::Values(5, 10));
46+
INSTANTIATE_TEST_SUITE_P_NOLINT(PicMatrixTests, NesterovATestTaskAll, ::testing::Values(5, 10));

‎tasks/all/example/perf_tests/main.cpp‎

Lines changed: 4 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -2,14 +2,12 @@
22
#include <mpi.h>
33

44
#include <chrono>
5-
#include <cstddef>
6-
#include <cstdint>
75
#include <memory>
86
#include <vector>
97

108
#include "all/example/include/ops_all.hpp"
119
#include "core/perf/include/perf.hpp"
12-
#include "core/task/include/task.hpp"
10+
#include "core/util/include/util.hpp"
1311

1412
class NesterovAllRunTest : public ::testing::TestWithParam<ppc::core::PerfResults::TypeOfRunning> {
1513
protected:
@@ -55,6 +53,6 @@ class NesterovAllRunTest : public ::testing::TestWithParam<ppc::core::PerfResult
5553

5654
TEST_P(NesterovAllRunTest, RunModes) { ExecuteTest(GetParam()); }
5755

58-
INSTANTIATE_TEST_SUITE_P(RunModeTests, NesterovAllRunTest,
59-
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
60-
ppc::core::PerfResults::TypeOfRunning::kTaskRun));
56+
INSTANTIATE_TEST_SUITE_P_NOLINT(RunModeTests, NesterovAllRunTest,
57+
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
58+
ppc::core::PerfResults::TypeOfRunning::kTaskRun));

‎tasks/mpi/example/func_tests/main.cpp‎

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
#include <string>
88
#include <vector>
99

10-
#include "core/task/include/task.hpp"
1110
#include "core/util/include/util.hpp"
1211
#include "mpi/example/include/ops_mpi.hpp"
1312

@@ -44,4 +43,4 @@ TEST_P(NesterovATestTaskMPI, MatmulFromFile) {
4443
EXPECT_EQ(in, test_task_mpi.Get());
4544
}
4645

47-
INSTANTIATE_TEST_SUITE_P(FileMatrixTestsMPI, NesterovATestTaskMPI, ::testing::Values(0.5, 1.0));
46+
INSTANTIATE_TEST_SUITE_P_NOLINT(FileMatrixTestsMPI, NesterovATestTaskMPI, ::testing::Values(0.5, 1.0));

‎tasks/mpi/example/perf_tests/main.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
#include <vector>
99

1010
#include "core/perf/include/perf.hpp"
11-
#include "core/task/include/task.hpp"
11+
#include "core/util/include/util.hpp"
1212
#include "mpi/example/include/ops_mpi.hpp"
1313

1414
class NesterovATaskMPITest : public ::testing::TestWithParam<ppc::core::PerfResults::TypeOfRunning> {
@@ -58,6 +58,6 @@ class NesterovATaskMPITest : public ::testing::TestWithParam<ppc::core::PerfResu
5858

5959
TEST_P(NesterovATaskMPITest, RunModes) { RunTest(GetParam()); }
6060

61-
INSTANTIATE_TEST_SUITE_P(NesterovATests, NesterovATaskMPITest,
62-
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
63-
ppc::core::PerfResults::TypeOfRunning::kTaskRun));
61+
INSTANTIATE_TEST_SUITE_P_NOLINT(NesterovATests, NesterovATaskMPITest,
62+
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
63+
ppc::core::PerfResults::TypeOfRunning::kTaskRun));

‎tasks/omp/example/func_tests/main.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ TEST_P(NesterovATestTaskOMP, MatmulFromFile) {
4444
EXPECT_EQ(in, test_task_omp.Get());
4545
}
4646

47-
INSTANTIATE_TEST_SUITE_P(FileMatrixTestsOMP, NesterovATestTaskOMP, ::testing::Values(0.5, 1.0));
47+
INSTANTIATE_TEST_SUITE_P_NOLINT(FileMatrixTestsOMP, NesterovATestTaskOMP, ::testing::Values(0.5, 1.0));

‎tasks/omp/example/perf_tests/main.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <vector>
88

99
#include "core/perf/include/perf.hpp"
10-
#include "core/task/include/task.hpp"
10+
#include "core/util/include/util.hpp"
1111
#include "omp/example/include/ops_omp.hpp"
1212

1313
class NesterovTaskOMPTest : public ::testing::TestWithParam<ppc::core::PerfResults::TypeOfRunning> {
@@ -53,6 +53,6 @@ class NesterovTaskOMPTest : public ::testing::TestWithParam<ppc::core::PerfResul
5353

5454
TEST_P(NesterovTaskOMPTest, RunModes) { RunTest(GetParam()); }
5555

56-
INSTANTIATE_TEST_SUITE_P(NesterovOMPTests, NesterovTaskOMPTest,
57-
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
58-
ppc::core::PerfResults::TypeOfRunning::kTaskRun));
56+
INSTANTIATE_TEST_SUITE_P_NOLINT(NesterovOMPTests, NesterovTaskOMPTest,
57+
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
58+
ppc::core::PerfResults::TypeOfRunning::kTaskRun));

‎tasks/seq/example/func_tests/main.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,4 +43,4 @@ TEST_P(NesterovATestTaskSeq, MatmulFromFile) {
4343
EXPECT_EQ(in, test_task_sequential.Get());
4444
}
4545

46-
INSTANTIATE_TEST_SUITE_P(FileMatrixTests, NesterovATestTaskSeq, ::testing::Values(0.5, 1.0));
46+
INSTANTIATE_TEST_SUITE_P_NOLINT(FileMatrixTests, NesterovATestTaskSeq, ::testing::Values(0.5, 1.0));

‎tasks/seq/example/perf_tests/main.cpp‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
#include <vector>
88

99
#include "core/perf/include/perf.hpp"
10-
#include "core/task/include/task.hpp"
10+
#include "core/util/include/util.hpp"
1111
#include "seq/example/include/ops_seq.hpp"
1212

1313
class NesterovTaskSeqTest : public ::testing::TestWithParam<ppc::core::PerfResults::TypeOfRunning> {
@@ -53,6 +53,6 @@ class NesterovTaskSeqTest : public ::testing::TestWithParam<ppc::core::PerfResul
5353

5454
TEST_P(NesterovTaskSeqTest, RunModes) { RunTest(GetParam()); }
5555

56-
INSTANTIATE_TEST_SUITE_P(NesterovSeqTests, NesterovTaskSeqTest,
57-
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
58-
ppc::core::PerfResults::TypeOfRunning::kTaskRun));
56+
INSTANTIATE_TEST_SUITE_P_NOLINT(NesterovSeqTests, NesterovTaskSeqTest,
57+
::testing::Values(ppc::core::PerfResults::TypeOfRunning::kPipeline,
58+
ppc::core::PerfResults::TypeOfRunning::kTaskRun));

‎tasks/stl/example/func_tests/main.cpp‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,4 +44,4 @@ TEST_P(NesterovATestTaskSTL, MatmulFromFile) {
4444
EXPECT_EQ(in, test_task_stl.Get());
4545
}
4646

47-
INSTANTIATE_TEST_SUITE_P(FileMatrixTestsSTL, NesterovATestTaskSTL, ::testing::Values(0.5, 1.0));
47+
INSTANTIATE_TEST_SUITE_P_NOLINT(FileMatrixTestsSTL, NesterovATestTaskSTL, ::testing::Values(0.5, 1.0));

0 commit comments

Comments
 (0)