Skip to content

Mark public Task class API with 'final' #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aobolensk merged 1 commit into from
May 13, 2025
Merged

Mark public Task class API with 'final' #381

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions modules/core/task/include/task.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,27 +25,27 @@ class Task {
explicit Task(TaskDataPtr task_data);

// set input and output data
void SetData(TaskDataPtr task_data);
virtual void SetData(TaskDataPtr task_data) final;

// validation of data and validation of task attributes before running
virtual bool Validation();
virtual bool Validation() final;

// pre-processing of input data
virtual bool PreProcessing();
virtual bool PreProcessing() final;

// realization of current task
virtual bool Run();
virtual bool Run() final;

// post-processing of output data
virtual bool PostProcessing();
virtual bool PostProcessing() final;

// get input and output data
[[nodiscard]] TaskDataPtr GetData() const;
[[nodiscard]] virtual TaskDataPtr GetData() const final;

virtual ~Task();

protected:
void InternalOrderTest(const std::string &str = __builtin_FUNCTION());
virtual void InternalOrderTest(const std::string &str = __builtin_FUNCTION()) final;
TaskDataPtr task_data;

// implementation of "validation" function
Expand Down
Loading