Skip to content

Mark public Task class API with 'final'#381

Merged
aobolensk merged 1 commit intolearning-process:masterfrom
aobolensk:task-class-final
May 13, 2025
Merged

Mark public Task class API with 'final'#381
aobolensk merged 1 commit intolearning-process:masterfrom
aobolensk:task-class-final

Conversation

@aobolensk
Copy link
Copy Markdown
Member

No description provided.

@aobolensk aobolensk requested review from allnes and Copilot May 12, 2025 22:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request updates the Task class API to mark its public methods as final, ensuring that these methods cannot be overridden in derived classes.

  • Mark public API methods (SetData, Validation, PreProcessing, Run, PostProcessing, GetData) as final.
  • Enforce immutability of the API interface by preventing further derivation of these methods.
Comments suppressed due to low confidence (1)

modules/core/task/include/task.hpp:48

  • The protected method 'InternalOrderTest' is marked as final despite the PR title specifying changes to the public API. Consider removing 'final' from this internal method if future internal overrides might be beneficial.
virtual void InternalOrderTest(const std::string &str = __builtin_FUNCTION()) final;

@github-actions github-actions Bot added the core label May 13, 2025
@aobolensk aobolensk merged commit 26eb045 into learning-process:master May 13, 2025
28 checks passed
@codecov
Copy link
Copy Markdown

codecov Bot commented May 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (a1fa76b) to head (5b581ac).
Report is 4 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #381   +/-   ##
=======================================
  Coverage   94.94%   94.94%           
=======================================
  Files          26       26           
  Lines         495      495           
  Branches      145      145           
=======================================
  Hits          470      470           
  Misses         12       12           
  Partials       13       13           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants