Mark public Task class API with 'final'#381
Merged
aobolensk merged 1 commit intolearning-process:masterfrom May 13, 2025
Merged
Mark public Task class API with 'final'#381aobolensk merged 1 commit intolearning-process:masterfrom
aobolensk merged 1 commit intolearning-process:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This pull request updates the Task class API to mark its public methods as final, ensuring that these methods cannot be overridden in derived classes.
- Mark public API methods (SetData, Validation, PreProcessing, Run, PostProcessing, GetData) as final.
- Enforce immutability of the API interface by preventing further derivation of these methods.
Comments suppressed due to low confidence (1)
modules/core/task/include/task.hpp:48
- The protected method 'InternalOrderTest' is marked as final despite the PR title specifying changes to the public API. Consider removing 'final' from this internal method if future internal overrides might be beneficial.
virtual void InternalOrderTest(const std::string &str = __builtin_FUNCTION()) final;
allnes
approved these changes
May 12, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #381 +/- ##
=======================================
Coverage 94.94% 94.94%
=======================================
Files 26 26
Lines 495 495
Branches 145 145
=======================================
Hits 470 470
Misses 12 12
Partials 13 13 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.