Skip to content

fix[sqlx-postgres]: do a checked_mul to prevent panic'ing #3919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
abonander merged 1 commit into from
Jul 4, 2025
Merged

fix[sqlx-postgres]: do a checked_mul to prevent panic'ing #3919

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 16 additions & 1 deletion sqlx-postgres/src/types/rust_decimal.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,9 @@ impl TryFrom<&'_ PgNumeric> for Decimal {
.checked_powi(weight as i64)
.ok_or("value not representable as rust_decimal::Decimal")?;

let part = Decimal::from(digit) * mul;
let part = Decimal::from(digit)
.checked_mul(mul)
.ok_or("value not representable as rust_decimal::Decimal")?;

value = value
.checked_add(part)
Expand Down Expand Up @@ -383,6 +385,19 @@ mod tests {
assert_eq!(actual_decimal.scale(), 0);
}

#[test]
fn mult_overflow() {
// -24_0711_6702_1036_7100_2022_8579_3280.00
let large_negative_number = PgNumeric::Number {
sign: PgNumericSign::Negative,
scale: 0,
weight: 7,
digits: vec![24, 0711, 6702, 1036, 7100, 2022, 8579, 3280],
};

assert!(Decimal::try_from(large_negative_number).is_err());
}

#[test]
fn max_value_max_scale() {
let mut max_value_max_scale = Decimal::MAX;
Expand Down
Loading