fix[sqlx-postgres]: do a checked_mul to prevent panic'ing#3919
Merged
abonander merged 1 commit intolaunchbadge:mainfrom Jul 4, 2025
Merged
Conversation
nhatcher-frequenz
force-pushed
the
bugfix/large_number_overflow
branch
from
2755345 to
c2849fc
Compare
Collaborator
|
Do you mind adding a regression test for this? |
Contributor
Author
|
Hi @abonander, there is already a regression test. Am I missing something? The test will fail without the fix |
Collaborator
|
Ah, sorry. I meant a test that actually tries to decode such a value from the database. But this is fine too. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This was discovered while reading very large negative numbers in a production PostgreSQL Database.
Without the fix the library will panic. Please see attached testcase.
Does your PR solve an issue?
I didn't find an open issue for this.
Is this a breaking change?
No. But before this change consumers of the library will panic.