Repository navigation
Port the local credential guard to the 0.1.10 rules - #29
Merged
Merged
Conversation
This copy of package-tools' scanner predated 0.1.10: it had no check that TestCredentials purposes are single words, which GitGuardian reads as passwords when they are not, and none of the false-positive exclusions. It is now the same port enumerator carries, and it declares itself (@credential-guard-copy reason=php-floor-below-package-tools mirrors=0.1.10) so package-tools' scheduled copy check catches the next drift instead of nobody.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: this repository carries a local port of
laranail/package-tools' credential scanner, because its CI tests PHP 8.3, below package-tools' floor. The port predated package-tools 0.1.10:TestCredentialspurposes are single words. GitGuardian reads a compound purpose as the password itself.new Password()literal or a dotted credential key.Change:
tests/Unit/NoLiteralCredentialsTest.phpis now the same 0.1.10 port enumerator carries. It has three tests: literals, purposes, and a self-check that the scanner recognises what it guards, plus a 9-file floor.@credential-guard-copy reason=php-floor-below-package-tools mirrors=0.1.10, so package-tools' new scheduledverify-credential-guard-copies.pycatches the next drift.Verification:
tests/TestCase.phpeach turned it red; restored afterwards.