Repository navigation
Check that local credential-guard copies keep up with the rules - #89
Merged
Merged
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why: a repository that cannot depend on package-tools carries a local port of the credential scanner, and nothing compared the port with the original. On 2026-10-20, notifications' copy was still on the pre-0.1.10 rules, with no purpose check and none of the false-positive exclusions, while three other copies were current. Nothing had failed.
What this adds:
CredentialLiterals::RULES_VERSION(0.1.10): the release in which the rules last changed.CredentialLiteralsRulesVersionTest: it pins a fingerprint of the scanner's source, so a rule cannot change without the version moving.scripts/verify-credential-guard-copies.py: it reusesverify-trait-copies.py's transport and sources, and checks every repository'sNoLiteralCredentialsTest.php.AssertsNoLiteralCredentialsis the shared guard and needs nothing.@credential-guard-copy reason=<slug> mirrors=<version>.php-floor-below-package-toolsoroutside-laranail) must still hold against that repository'scomposer.json.mirrorsmust equalRULES_VERSION.docs/tools/test-credentials.md.[Unreleased].Already landed: the four copies' declarations, and notifications' port to 0.1.10:
Verification:
VerifyCredentialGuardCopiesScriptTest):laranail-pint --test, PHPStan and Rector all pass.