Skip to content

test(e2e): read the target errors from the action shots #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
koji-1009 merged 1 commit into from
Sep 23, 2026
Merged

test(e2e): read the target errors from the action shots #13

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions test/e2e/actions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,16 +35,25 @@ Widget twoButtons() => Row(
});
const buttons = 'lib/preview/button_state_preview.dart';
final (plain, _) = await shoot([buttons]);
for (final action in [
['--press', 'text:Save'],
['--hover', 'type:ElevatedButton'],
['--focus', 'type:ElevatedButton'],
// The two Save buttons match text:Save twice and type:ElevatedButton
// not at all.
for (final (action, twoError) in [
(['--press', 'text:Save'], 'press text:Save: 2 widgets match; name one'),
(
['--hover', 'type:ElevatedButton'],
'hover type:ElevatedButton: no widget matches',
),
(
['--focus', 'type:ElevatedButton'],
'focus type:ElevatedButton: no widget matches',
),
]) {
final (run, shots) = await shoot([buttons, ...action]);
final button = shots['State / button']!;
expect(button.status, ShotStatus.ok, reason: '$action ${button.error}');
expect(button.size, (200.0, 80.0));
final two = shots['State / two buttons']!;
expect(two.error, twoError);
expect(two.png, isNull);
expect(two.at, startsWith('lib/preview/button_state_preview.dart:'));
final diff = await shutter(root, ['diff', plain, run]);
Expand All @@ -58,19 +67,5 @@ Widget twoButtons() => Row(
);
expect(entry['status'], 'changed', reason: '$action');
}
final (_, missed) = await shoot([buttons, '--tap', 'text:Cancel']);
expect(
missed['State / button']!.error,
'tap text:Cancel: no widget matches',
);
expect(
missed['State / two buttons']!.error,
'tap text:Cancel: no widget matches',
);
final (_, twice) = await shoot([buttons, '--press', 'text:Save']);
expect(
twice['State / two buttons']!.error,
'press text:Save: 2 widgets match; name one',
);
});
}
Loading