test(e2e): read the target errors from the action shots - #13
Merged
Merged
Conversation
The press shot was taken twice: once in the loop, and again to read the two-buttons error. The tap on text:Cancel took one more shot for the no-match error, which the hover and focus shots already produce: every action finds its target the same way. Each action shot now checks the two-buttons error, and the two extra shots are gone. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The actions test took the
--press text:Saveshot twice: once in the loop, and again only to read the error ofState / two buttons.It also took a
--tap text:Cancelshot for the "no widget matches" error, which the--hoverand--focusshots oftype:ElevatedButtonalready produce forState / two buttons; the harness finds every action's target through the same_target.Each action shot in the loop now checks the error of
State / two buttons, and the two extra shots (twoflutter testruns) are gone.🤖 Generated with Claude Code