Repository navigation
test: repair smoke + byok suites after upstream sync (fixes failing Source verification) - #11
Merged
Merged
Conversation
…ptional catalog, stateless provider-add checks) Post-merge (PR #7/#9) the Source verification workflow failed test:smoke on all platforms (9 failures). Three root causes: 1. 'shared user config' probed 'mcode telemetry status', removed by the fork's telemetry-removal commit; the top-level [prompt] argument then swallowed 'status' ('too many arguments'). Probe via 'provider list --json' instead and keep the no-migration assertion (~/.minimax-code untouched). The config fixture moves off telemetry: keys, which this distribution does not parse. 2. Offline proxy children asserted a models.dev request lands in the '.managed' audit log. The catalog request is optional: with the fork's default-deny egress guard installed the ProxyAgent connect path is denied and the CLI keeps a cached catalog, so the file never exists. Adopt upstream ec38e13 (state-independent proxy assertions, NO_PROXY coverage added). 3. 'provider add' asserted no config.yaml is created, but startup seeds defaults (logLevel/defaultModel) in the fixture cwd. Adopt upstream ec38e13's replacement: data dir separated from cwd, both fresh and seeded variants, assert no custom_provider is persisted. Local: node --test test/smoke.test.mjs -> 21 tests, 20 pass, 1 skip (macOS-only chflags test), 0 fail.
test:byok failed on all three platforms since the e26 sync (PR #9 brought upstream MiniMax-AI#172's 'offline BYOK ignores ambient proxies' group): each subtest reads network-audit.log.managed and expects a models.dev / models-dev catalog request to have been logged. On this fork the request never reaches the offline fixture: the CLI entry point installs the default-deny egress guard (PR #1/#4) before any product module loads, and the catalog descriptor lives on an always-refused managed host (agent.minimax.*). The guard rejects in-process, so the fixture's .managed log is never created (ENOENT). Upstream passes because its CLI has no guard and its network-deny fixture logs the attempt. Upstream itself ruled this assertion unreliable in ec38e13 ('Catalog requests are optional'). Keep the meaningful assertions — the local provider must still receive the request and the strict deny-log must stay empty — and drop only the managed-catalog delta. Local: MCODE_TEST_MANAGED_OFFLINE byok suite -> 11 tests, 11 pass, 0 fail.
tournierjc
changed the title
This was referenced Sep 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Since PR #7 (upstream sync a5639bc) the Source verification workflow failed
test:smokeon every platform; once smoke is fixed,test:byokfails on every platform too (verified on PR #11 run 35505758508: 12 gates green,test:byokFAIL). Reproduced locally: smoke 9 fail / byok 11 fail.Root causes (all fork-vs-upstream divergences)
mcode telemetry status— removed by the fork's telemetry removal (2714d44); the top-level[prompt]argument swallowedstatus→ "too many arguments".network-attempts.log.managed. Upstream itself ruled that request optional in ec38e13; with the fork's default-deny egress guard installed the attempt is refused in-process and the.managedfile is never created → ENOENT.provider addassertedconfig.yamlis never created, but startup seeds defaults in the fixture cwd → false failure.agent.minimax.*in-process, so the fixture never sees it → ENOENT. Upstream's offline fixture returns a 503 stub whose body can't pass the descriptor URL parse, so the.managedlog on this fork can only ever be empty — the assertion is unsatisfiable here by construction.Fix (test-only, no product code)
test/smoke.test.mjs: fork-adapted config probe viaprovider list --json(keeps the no-migration assertion; supersedes fix: post-merge wording + smoke test without telemetry command #10); adopt upstream ec38e13 for the proxy test and theprovider add rejects invalid token limits without saving a providerreplacement.test/byok.test.mjs: drop only the managed-catalog delta assertion (same rationale upstream used in ec38e13: catalog requests are optional). Local-provider-received and empty-deny-log assertions stay.Local evidence
test:smoke: 21 tests, 20 pass, 1 skip (macOS chflags), 0 fail (was 9 fail).test:byok: 11/11 pass (was 0/11).check:source✓,check:tsconfig✓,test:release-tools✓ 21/22,test:status-contract✓ 9/9,check:standalone✓,check:egress✓,test:artifact✓ 4/4,test:policy✓ 142/142,test:capabilities✓ (CI run).Supersedes #10 (same smoke fix, broader scope).