Skip to content

reap orphaned chromium/crashpad children to prevent zombie accumulation #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tespio wants to merge 1 commit into
base: main
Choose a base branch
from
Open

reap orphaned chromium/crashpad children to prevent zombie accumulation #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 21 additions & 0 deletions main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,13 +2,34 @@ package main

import (
"os"
"os/signal"
"syscall"

"github.com/karust/openserp/cmd"
"github.com/sirupsen/logrus"
)

// reapZombies installs a SIGCHLD reaper so that any child that is killed or
// orphaned outside rod's own cmd.Wait() (e.g. Chromium/headless-shell or its
// crashpad handler after an aborted captcha/search request) is reclaimed
// instead of accumulating as a zombie for the lifetime of the server.
func reapZombies() {
ch := make(chan os.Signal, 1)
signal.Notify(ch, syscall.SIGCHLD)
for range ch {
for {
var ws syscall.WaitStatus
pid, err := syscall.Wait4(-1, &ws, syscall.WNOHANG, nil)
if err != nil || pid <= 0 {
break
}
}
}
}

func main() {
defer recoverPanic()
go reapZombies()

if err := cmd.RootCmd.Execute(); err != nil {
// Cobra already prints the error to stderr; just set the exit code.
Expand Down