Conversation
When a search request is aborted (captcha hang, client timeout) the browser process group is SIGKILLed. The browser's crashpad/vassal children survive long enough to be reparented to this process, which in the shipped container is PID 1 with no external init, so nothing ever reaps them and the process leaks zombies until the server exits (~4 per aborted query observed). Rod already waits on its direct browser child; this reaper simply reclaims whatever rod's Wait does not cover (races are harmless: the loser's wait returns ECHILD and is ignored). Healthy searches are unaffected.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a search request is aborted (CAPTCHA hang on a blacklisted IP, client timeout), the browser process group is SIGKILLed. The browser's crashpad / vassal children survive long enough to be reparented to this process — and in the shipped container this process is PID 1 with no external init, so unless it reaps them, nothing ever does.
Observed in production: ~4 zombie processes accumulated per aborted query (~120/day), unbounded until the container restarts, because rod only waits on its direct browser child (the crashpad orphans land on PID 1 and stay).