Repository navigation
Bump NUnit and NUnit3TestAdapter - #151
Merged
Merged
Conversation
Bumps NUnit from 4.6.1 to 5.0.0 Bumps NUnit3TestAdapter from 6.2.0 to 6.3.1 --- updated-dependencies: - dependency-name: NUnit dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: testing - dependency-name: NUnit3TestAdapter dependency-version: 6.3.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: testing ... Signed-off-by: dependabot[bot] <support@github.com>
- Await Assert.ThrowsAsync/CatchAsync, which now return Task<T>. Six calls in synchronous test methods compiled without warning but no longer asserted anything; those methods are now async - Narrow Has.Some.Matches lambda parameter, now nullable, via pattern match - Remove obsolete [Order]; SetUp/TearDown already reset NativeCodecs state
…ing-aead52b863 # Conflicts: # Directory.Packages.props
Adapter 6.3.x makes the MTP code coverage extension search the whole working directory recursively for modules to statically instrument, instead of the test assembly's output directory. With all test projects running in parallel under --coverage, each host rewrites the others' binaries; locally a single project goes from 3s to ~60s and the full run hangs, and on CI the test step stalled until the runner was shut down. NUnit 5.0.0 works with adapter 6.2.0. Ignore 6.3.0/6.3.1 in Dependabot.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #151 +/- ##
==========================================
- Coverage 65.66% 65.63% -0.03%
==========================================
Files 337 337
Lines 30420 30420
Branches 5710 5710
==========================================
- Hits 19974 19967 -7
- Misses 9028 9033 +5
- Partials 1418 1420 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated NUnit from 4.6.1 to 5.0.0.
Release notes
Sourced from NUnit's releases.
5.0.0
See release notes for details.
Commits viewable in compare view.
Updated NUnit3TestAdapter from 6.2.0 to 6.3.1.
Release notes
Sourced from NUnit3TestAdapter's releases.
6.3.1
This is a hotfix release for issue 1504
6.3.0
See Release notes
Commits viewable in compare view.
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore <dependency name> major versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's major version (unless you unignore this specific dependency's major version or upgrade to it yourself)@dependabot ignore <dependency name> minor versionwill close this group update PR and stop Dependabot creating any more for the specific dependency's minor version (unless you unignore this specific dependency's minor version or upgrade to it yourself)@dependabot ignore <dependency name>will close this group update PR and stop Dependabot creating any more for the specific dependency (unless you unignore this specific dependency or upgrade to it yourself)@dependabot unignore <dependency name>will remove all of the ignore conditions of the specified dependency@dependabot unignore <dependency name> <ignore condition>will remove the ignore condition of the specified dependency and ignore conditionsSummary by cubic
Updates
NUnitfrom 4.6.1 to 5.0.0 and holdsNUnit3TestAdapterat 6.2.0. The 6.3.x adapter makes the MTP code coverage extension instrument every DLL under the repo root instead of the test bin dir, so parallel test hosts rewrite each other's binaries and CI hangs; a Dependabot ignore rule excludes 6.3.0 and 6.3.1.Also adapts the test suite to NUnit 5 API changes:
Assert.ThrowsAsync/CatchAsynccalls are now awaited (six previously unasserted calls in sync test methods are now async), sequence assertions use pattern matching for the now-nullable lambda parameter, and the obsolete[Order]attribute inNativeCodecsTestsis removed.Written for commit c0c08d3. Summary will update on new commits.