Repository navigation
Bump NUnit and NUnit3TestAdapter - #149
Closed
dependabot[bot] wants to merge 1 commit into
Closed
dependabot[bot] wants to merge 1 commit into
dependabot[bot] wants to merge 1 commit into
Conversation
dependabot
Bot
added
.NET
jas88
added a commit
that referenced
this pull request
Oct 14, 2026
## Summary Verify 33.x (pulled in by #149) adds a SponsorCheck build gate that fails the build (SC021) unless a sponsorship/licence MSBuild property is declared. Verify was only used by the 14 source generator snapshot tests, so this replaces it with a small in-house helper and drops the dependency. - Add `GeneratorSnapshot`, which compares each generated source against the existing `{Class}.{Test}#{HintName}.verified.cs` files (unchanged), writes `.received.cs` on mismatch, flags stale snapshots, and fails on generator diagnostics or exceptions - Exclude `*.verified.cs` / `*.received.cs` from compilation in both test projects (previously done by Verify's MSBuild targets) - Remove `Verify.NUnit` / `Verify.SourceGenerators` and the `Verify*` Dependabot group pattern - Fix `NativeCodecsTests.Initialize_WithEnableOptions_SetsProperties`: enable options are applied before the native library is probed, so the library-unavailable branch asserted the wrong values (only reproducible where the native library is absent) ## Testing - Solution builds with 0 warnings / 0 errors - Full test suite passes on net10.0 locally - Confirmed a deliberately altered snapshot fails with a clear message and writes a `.received.cs` file After this merges, #149 only needs the NUnit 5 API fixes. <!-- This is an auto-generated description by cubic. --> --- ## Summary by cubic Verify 33.x adds a SponsorCheck build gate that fails the build unless a sponsorship MSBuild property is declared. Verify was only used for the 14 source generator snapshot tests, so this replaces it with a small in-house helper and drops the dependency. - Adds `GeneratorSnapshot`, which compares each generated source against the existing `{Class}.{Test}#{HintName}.verified.cs` files, writes `.received.cs` on mismatch, flags stale snapshots, and fails on generator diagnostics or exceptions. - Excludes `*.verified.cs` and `*.received.cs` from compilation in both test projects (previously handled by Verify's MSBuild targets). - Removes `Verify.NUnit`, `Verify.SourceGenerators`, and the `Verify*` Dependabot pattern. - Fixes `NativeCodecsTests.Initialize_WithEnableOptions_SetsProperties`: enable options are applied before the native library is probed, so the library-unavailable branch was asserting the wrong values. - Maps CI-recorded `/ _/` source paths back to the repository root, measured via a `RepositoryRoot` assembly metadata item, so snapshot files resolve in deterministic builds. <sup>Written for commit fac71e3. Summary will update on new commits.</sup> <a href="https://cubic.dev/pr/jas88/SharpDicom/pull/150?utm_source=github" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img alt="View guided diff" src="https://www.cubic.dev/buttons/review-in-cubic-light.svg"></picture></a> <a href="https://www.cubic.dev/action/auto-fix/pr/jas88/SharpDicom/150?returnTo=https%3A%2F%2Fgithub.com%2Fjas88%2FSharpDicom%2Fpull%2F150&source=description" target="_blank" rel="noopener noreferrer" data-no-image-dialog="true"><picture><source media="(prefers-color-scheme: dark)" srcset="https://www.cubic.dev/buttons/turn-on-auto-fix-dark.svg"><source media="(prefers-color-scheme: light)" srcset="https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"><img alt="Turn on auto-fix" src="https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"></picture></a> <!-- End of auto-generated description by cubic. -->
dependabot
Bot
changed the title
dependabot
Bot
force-pushed
the
dependabot/nuget/testing-55b4c50b30
branch
from
October 19, 2026 01:28
71ee7f9 to
cb873a3
Compare
Owner
|
@dependabot rebase |
Bumps NUnit from 4.6.1 to 5.0.0 Bumps NUnit3TestAdapter from 6.2.0 to 6.3.1 --- updated-dependencies: - dependency-name: NUnit dependency-version: 5.0.0 dependency-type: direct:production update-type: version-update:semver-major dependency-group: testing - dependency-name: NUnit3TestAdapter dependency-version: 6.3.1 dependency-type: direct:production update-type: version-update:semver-minor dependency-group: testing - dependency-name: Verify.NUnit dependency-version: 33.3.3 dependency-type: direct:production update-type: version-update:semver-major dependency-group: testing ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
Bot
force-pushed
the
dependabot/nuget/testing-55b4c50b30
branch
from
October 20, 2026 17:01
cb873a3 to
5c7ad41
Compare
Owner
|
Superseded by #151, which includes the test fixes required for NUnit 5. |
Contributor
Author
|
This pull request was built based on a group rule. Closing it will not ignore any of these versions in future pull requests. To ignore these dependencies, configure ignore rules in dependabot.yml |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
![https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source](https://www.cubic.dev/buttons/review-in-cubic-dark.svg"><source){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img](https://www.cubic.dev/buttons/review-in-cubic-light.svg"><img){kind=link}
![https://www.cubic.dev/buttons/review-in-cubic-light.svg"></picture></a](https://www.cubic.dev/buttons/review-in-cubic-light.svg"></picture></a){kind=link}
![https://www.cubic.dev/buttons/turn-on-auto-fix-dark.svg"><source](https://www.cubic.dev/buttons/turn-on-auto-fix-dark.svg"><source){kind=link}
![https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"><img](https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"><img){kind=link}
![https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"></picture></a](https://www.cubic.dev/buttons/turn-on-auto-fix-light.svg"></picture></a){kind=link}
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated NUnit from 4.6.1 to 5.0.0.
Release notes
Sourced from NUnit's releases.
5.0.0
See release notes for details.
Commits viewable in compare view.
Updated NUnit3TestAdapter from 6.2.0 to 6.3.1.
Release notes
Sourced from NUnit3TestAdapter's releases.
6.3.1
This is a hotfix release for issue 1504
6.3.0
See Release notes
Commits viewable in compare view.