Skip to content

fix(ui): prevent node/edge deletion when workflow viewer is not editing #191

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
isaacwasserman merged 1 commit into from
Sep 14, 2026
Merged

fix(ui): prevent node/edge deletion when workflow viewer is not editing #191

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/prevent-view-mode-node-delete.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"@remoraflow/ui": patch
---

Prevent node deletion in the workflow viewer when editing is disabled. React Flow's built-in delete-key handler removed selected nodes even in view mode; the delete key is now disabled and `remove` node changes are ignored unless `isEditing` is true.
24 changes: 20 additions & 4 deletions packages/ui/src/workflow-viewer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ import {
type EdgeTypes,
MiniMap,
type NodeTypes,
type OnEdgesChange,
type OnNodesChange,
ReactFlow,
useEdgesState,
Expand Down Expand Up @@ -356,12 +357,26 @@ export function WorkflowViewer({
]);

const [nodes, setNodes, onNodesChangeBase] = useNodesState(layout.nodes);
const [edges, setEdges, onEdgesChange] = useEdgesState(layout.edges);
const [edges, setEdges, onEdgesChangeBase] = useEdgesState(layout.edges);

const onEdgesChange: OnEdgesChange = useCallback(
(changes) => {
onEdgesChangeBase(
isEditing
? changes
: changes.filter((change) => change.type !== "remove"),
);
},
[onEdgesChangeBase, isEditing],
);

const onNodesChange: OnNodesChange = useCallback(
(changes) => {
onNodesChangeBase(changes);
for (const change of changes) {
const applied = isEditing
? changes
: changes.filter((change) => change.type !== "remove");
onNodesChangeBase(applied);
for (const change of applied) {
if (
change.type === "dimensions" &&
change.dimensions?.width &&
Expand All @@ -374,7 +389,7 @@ export function WorkflowViewer({
}
}
},
[onNodesChangeBase],
[onNodesChangeBase, isEditing],
);

useEffect(() => {
Expand Down Expand Up @@ -973,6 +988,7 @@ export function WorkflowViewer({
minZoom={0.1}
nodesDraggable={isEditing}
nodesConnectable={isEditing}
deleteKeyCode={isEditing ? undefined : null}
defaultEdgeOptions={{
type: "workflow",
}}
Expand Down
Loading