fix(ui): prevent node/edge deletion when workflow viewer is not editing - #191
Merged
Merged
Conversation
React Flow's built-in delete-key handler removed selected nodes and edges even when isEditing was false. Disable deleteKeyCode in view mode and drop remove changes from onNodesChange/onEdgesChange unless editing. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow viewer let users delete nodes in view mode because React Flow's built-in delete-key handler is not gated by
isEditing— only the component's custom handlers were. This disablesdeleteKeyCodewhen not editing and dropsremovechanges fromonNodesChange/onEdgesChangeunlessisEditingis true, so selecting a node/edge and pressing Delete/Backspace no longer mutates a read-only viewer. Selection stays enabled to keep the read-only detail panel working. Includes a changeset (@remoraflow/uipatch).🤖 Generated with Claude Code