Repository navigation
Make captions again once a project has some - #187
Merged
Merged
Conversation
The phone's Captions screen had no way back to Auto captions, and the tablet offered it only while there were no captions. The phone's model line now opens the setup, which says how many captions it replaces, and the tablet inspector has the Transcribe tab of the design. Running again keeps the captions' look and layer, drops their translations and captions the clips added since. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #181
Once a project had captions, Auto captions couldn't be run again: the phone's Captions tool opened the Captions screen, which had no way back, and the tablet offered Auto captions only while there were none. So clips added later couldn't get captions, and captions couldn't be made again with another model or language.
Phone. The Captions screen's model line ("Whisper Small · Polish ⌄") is now a button to the Auto captions setup. The CaptionsEdit board has no control for this, so this is the difference from the design: the line was already there and says what the captions were made with, so it leads to where that is changed (
ScreenHeadertakes an optionalonSubtitle, with a chevron and a TalkBack label). Generating returns to the Captions screen it came from. Above Generate, the setup says how many captions it replaces: "Replaces the 6 captions made from these clips, edits included".Tablet. The captions inspector has the Style and Transcribe tabs of
TabletCaptions--transcribe-tab: the Whisper models with their real sizes and state, the language, Translate to English, and "Regenerate with Base" ("Generate with Base" when there are no captions), with progress and Cancel while it runs. It hears the clips with captions again, plus the main clips, so clips added since get captions. Difference from the board: the language and Translate sit one under the other, because side by side the language was cut off ("Auto-det…", "Autom…" in Polish), and a model's size goes under its name when both don't fit.Running again (
CreateCaptions,core:model), one undo step:Tests:
CaptionCommandsTest.runningAgainKeepsTheLookAndLayerAndCaptionsNewClipsCaptionsSetupScreenTest.generatingAgainReplacesTheCaptionsCaptionsEditScreenTest.captionsAsDesignedtaps the model lineCaptionsPanelsTest.tabletTranscribeandtabletTranscribeInPolish(new screenshots); the other captions screenshots were recorded again for the chevron and the tabsChecked on the emulator with a real project (captions from a talk in Polish made with Whisper Small, Karaoke, on a layer that also holds text clips):
🤖 Generated with Claude Code