Repository navigation
Delete one caption without its source or the others - #186
Merged
Merged
Conversation
Deleting a caption took its source clip and every other caption from it, since they share one link group, and ripple then moved the next sources back by the caption's length. A caption now goes alone and never ripples. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #179
Deleting one caption clip from the timeline removed the caption, its source video and every other caption made from that video, because a source and its captions share one link group and
DeleteCliptakes all linked partners. With ripple on, the captions after it then moved back by the caption's length and dragged their own source clips with them, leaving a gap on L1.Now
DeleteClipon a caption removes only that caption (it leaves its link group) and never ripples, so the other captions stay on their words. Deleting a source clip still removes its captions, and a detached sound and its video still go together.core/model/.../edit/ClipCommands.kt: the caption case inDeleteClip.CaptionCommandsTest.aDeletedCaptionGoesAloneAndTheSourceTakesItsCaptions: ripple on and off, the link kept, undo, and the source still taking its captions. It fails onmain.docs/architecture.md: the caption clips note says so.No UI change. The existing delete tests (
ClipCommandsTest,DetachedSoundTest) pass unchanged.🤖 Generated with Claude Code