Repository navigation
Keep undone text words undone in the tablet inspector - #178
Merged
Merged
Conversation
The tablet Text inspector kept its own draft of the selected clip's words and wrote it back when the selection moved on. After Undo restored a title's words, the inspector still showed the typed ones, and leaving the clip put them back, so the undo was lost. The draft now takes words that change from outside (undo, redo) and only commits what was typed. rememberWords holds that logic and has a test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Found while making the demo video in the tablet editor.
Problem
Change
rememberWords(inTextPanels.kt) now owns the draft:Tests
TextPanelsTest.undoneWordsStayUndone: type, commit, undo, deselect. Without the fix it fails withexpected:<Clipra> but was:<Clipra demo>.:feature:text:testDebugUnitTest,:app:compileDebugKotlinandspotlessCheckpass.🤖 Generated with Claude Code