Repository navigation
feat(events): the published panel says who the event is for - #136
Open
Saul-Gomez-J wants to merge 1 commit into
Open
Saul-Gomez-J wants to merge 1 commit into
Saul-Gomez-J wants to merge 1 commit into
Conversation
"Abierto a todos" was shown on every published informative event, which is false for the workshops held as Discord events of the private NaN server. Read `ev.access` (B-28, helmcode/nan-events-backend#3) and pick the copy: "members" → "Solo para la comunidad de NaN", "open" → "Abierto a todos", empty → neutral "Evento anunciado". The CTA is unchanged. Guards: the page branches on the field with the neutral fallback, both locales carry the three variants and only the open one says "everyone". Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014ToscGMqPkLEBZ6x8MhcP7
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Every published informative event showed "Abierto a todos", which is false for the workshops held as Discord events of the private NaN server.
What
ev.access(B-28, backend PR helmcode/nan-events-backend#3) in the published panel of/events/{slug}:members→ "Solo para la comunidad de NaN" / "NaN members only"open→ "Abierto a todos" / "Open to everyone"EventInfo/PublicEventSummarycarryaccess; calendar fixture updated.eventsUiGuards.test.ts: the page branches on the field with the neutral fallback, both locales carry the three variants and only the open one says "everyone".Safe to merge before the backend: until the API sends
access, the page falls through to the neutral copy.npm test(1327 passed) andastro check(0 errors) are green.🤖 Generated with Claude Code
https://claude.ai/code/session_014ToscGMqPkLEBZ6x8MhcP7