Skip to content

Make default_render failures not set an error cause #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gmcgibbon wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make default_render failures not set an error cause #257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions lib/action_controller/responder.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -192,14 +192,14 @@ def to_js
# responds to :to_format and display it.
#
def to_format
if !get? && has_errors? && !response_overridden?
display_errors
elsif has_view_rendering? || response_overridden?
default_render
else
api_behavior
begin
if !get? && has_errors? && !response_overridden?
return display_errors
elsif has_view_rendering? || response_overridden?
return default_render
end
rescue ActionView::MissingTemplate
end
rescue ActionView::MissingTemplate
api_behavior
end

Expand Down
8 changes: 8 additions & 0 deletions test/action_controller/respond_with_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -732,6 +732,14 @@ def test_raises_missing_renderer_if_an_api_behavior_with_no_renderer
end
end

def test_api_behavior_error_is_not_caused_by_missing_template
@controller = CsvRespondWithController.new
error = assert_raise ActionController::MissingRenderer do
get :index, format: "csv"
end
assert_nil error.cause
end

def test_error_is_raised_if_no_respond_to_is_declared_and_respond_with_is_called
@controller = EmptyRespondWithController.new
@request.accept = "*/*"
Expand Down