Make default_render failures not set an error cause - #257
Open
gmcgibbon wants to merge 1 commit into
Open
Conversation
A default_render that fails should not set a cause of a subsequent api_behavior call if it results in an exception in Responder#to_format.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed in my app that when
api_behaviourraises an error, the cause is set toActionView::MissingTemplatefor some reason, and it turns out thisrescueis why. Adefault_renderthat fails should not set a cause of a subsequentapi_behaviorcall if it results in an exception inResponder#to_format.