otel: subchannel metrics - #12202

Merged

AgraVator merged 12 commits into

grpc:masterfrom

AgraVator:otel-subchannel-metrics

Sep 8, 2025

AgraVator commented Jul 7, 2025 •

edited

Loading

Contributor

Implements A94

AgraVator marked this pull request as ready for review

July 9, 2025 10:05

AgraVator requested review from ejona86 and kannanjgithub

July 9, 2025 10:05

AgraVator force-pushed the otel-subchannel-metrics branch from eabbf58 to 9595507 Compare

July 15, 2025 10:00

AgraVator commented

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated

AgraVator added 8 commits

July 22, 2025 23:25


          otel: subchannel metrics

a06568c


          otel: add LongUpDownCounterMetricInstrument

daf901b


          otel: add LongUpDownCounterMetricInstrument

735665b


          otel: plumb optional labels other than disconnect_error

a664b2f


          otel: fixes NPE

2ce087e


          otel: formatting fixes

2293e7f


          add test case

623c0f9


          logs the metrics inside sync context

c713561

AgraVator force-pushed the otel-subchannel-metrics branch from 9595507 to c713561 Compare

July 22, 2025 17:55

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/ManagedChannelImpl.java

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/PickFirstLeafLoadBalancer.java Outdated

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/DelayedClientTransport.java Outdated

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated

kannanjgithub reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/MetricRecorderImpl.java

kannanjgithub reviewed

View reviewed changes

opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricSink.java

kannanjgithub reviewed

View reviewed changes

api/src/main/java/io/grpc/MetricInstrumentRegistry.java


          reframe comments

ca8e9ed

ejona86 reviewed

View reviewed changes

core/src/main/java/io/grpc/internal/MetricRecorderImpl.java

core/src/main/java/io/grpc/internal/InternalSubchannel.java Outdated

core/src/main/java/io/grpc/internal/OtelMetricsAttributes.java Outdated

core/src/main/java/io/grpc/internal/SubchannelMetrics.java Outdated

api/src/main/java/io/grpc/LoadBalancer.java Outdated


          suggested changes

b45a907

AgraVator requested review from ejona86 and kannanjgithub

July 29, 2025 09:17

kannanjgithub requested changes

View reviewed changes

kannanjgithub left a comment

Contributor

.

opentelemetry/src/main/java/io/grpc/opentelemetry/OpenTelemetryMetricSink.java


          LongUpDownCounter: add test case

kannanjgithub approved these changes

View reviewed changes

ejona86 approved these changes

View reviewed changes

core/src/main/java/io/grpc/internal/SubchannelMetrics.java Outdated

api/src/main/java/io/grpc/EquivalentAddressGroup.java Outdated


          use parameterName

d407cfa

ejona86 approved these changes

View reviewed changes

AgraVator merged commit d4e1b69 into grpc:master

16 checks passed

jdcormie pushed a commit to jdcormie/grpc-java that referenced this pull request


          otel: subchannel metrics A94 (grpc#12202)

071e03d

Implements [A94](https://github.com/grpc/proposal/pull/485/files) except for the exact reason for disconnect_error

ejona86 mentioned this pull request

xds: Convert ClusterResolverLb to XdsDepManager #12361

Merged

github-actions Bot locked as resolved and limited conversation to collaborators

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet