xds: Convert ClusterResolverLb to XdsDepManager - #12361
Merged
Merged
Conversation
Contributor
|
A61 says there will be a single Endpoint comprised of all the logical DNS addresses but we are still creating one endpoint for each address. |
ejona86
force-pushed
the
clusterresolver-to-xdsdepman
branch
from
September 17, 2025 16:42
1233254 to
fc652ec
Compare
Member
Author
|
Rebased past #12202, just fixing |
kannanjgithub
approved these changes
Sep 18, 2025
kannanjgithub
left a comment
kannanjgithub
left a comment
Contributor
There was a problem hiding this comment.
Merge conflict is there.
No longer need to hard-code pick_first because of gRFC A61. grpc/proposal#477
Yes, that was a bug discovered in OutlierDetection (EnvoyServerProtoData). And yes, now XdsDepManager combines EAGs into a single endpoint.
ejona86
force-pushed
the
clusterresolver-to-xdsdepman
branch
from
September 18, 2025 17:13
fc652ec to
029d825
Compare
Member
Author
|
@shivaspeaks, you should be unblocked for the XdsClient changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No longer need to hard-code pick_first because of gRFC A61.
grpc/proposal#477
This is still a WIP but I wanted to start the review as the remaining work is mostly tests at this point. (Yes, I there is one small TODO still in the main code.)This leaves ClusterResolverLb in-place. It'd be a follow-up to combine it with CdsLb. The tests include xdsDepManager instead of faking the XdsConfig object, which should make that PR easier, as well as many refactorings.
I'm almost to the logical dns tests, which will be the point
XdsDependencyManager.enableLogicalDnswill flip to true, as I can properly test it (and it is required).