Skip to content

test(react-router): Match error and segment span by trace in instrumentation API e2e test #25607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mydea wants to merge 1 commit into
base: develop
Choose a base branch
from
+13 −5
Open

test(react-router): Match error and segment span by trace in instrumentation API e2e test #25607

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions ...-applications/react-router-7-framework-instrumentation/tests/errors/errors.server.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,5 @@
import { expect, test } from '@playwright/test';
import type { SerializedStreamedSpan } from '@sentry-internal/test-utils';
import {
collectStreamedSpansUntilSegment,
getSpanOp,
Expand Down Expand Up @@ -72,18 +73,25 @@ test.describe('server - instrumentation API error capture', () => {
return errorEvent.exception?.values?.[0]?.value === 'Loader error for testing';
});

const spanPromise = waitForStreamedSpan(APP_NAME, span => {
return span.name === 'GET /performance/error-loader' && span.is_segment;
// Streamed spans flush later than errors, so a segment span from an earlier test hitting the same
// route can still be arriving here. Collect them and look for the one in the error's trace.
const segmentSpans: SerializedStreamedSpan[] = [];
void waitForStreamedSpan(APP_NAME, span => {
if (span.name === 'GET /performance/error-loader' && span.is_segment) {
segmentSpans.push(span);
}
return false;
});

await page.goto(`/performance/error-loader`).catch(() => {
// Expected to fail due to loader error
});

const [error, span] = await Promise.all([errorPromise, spanPromise]);
const error = await errorPromise;
const traceId = error.contexts?.trace?.trace_id;
expect(traceId).toMatch(/^[a-f0-9]{32}$/);

// Error and segment span should have the same trace_id
expect(error.contexts?.trace?.trace_id).toBe(span.trace_id);
await expect.poll(() => segmentSpans.some(span => span.trace_id === traceId)).toBe(true);
});

// Skipped in dev: the action error is sometimes captured via the client instrumentation path
Expand Down
Loading