Repository navigation
Conversation
…ntation API e2e test Streamed spans flush after errors, so the segment span listener could pick up a late span from an earlier test that hit the same route, making the trace id assertion flaky (mostly in dev mode). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
size-limit report 📦Compared: 0b5eac7 (PR test merge using develop at 32e7a35) Against: 32e7a35 (develop) · base run #62893 ✅ Baseline matches: this diff contains only this PR's changes.
|
mydea
marked this pull request as ready for review
October 21, 2026 11:37
mydea
requested review from
a team,
chargome and
s1gr1d
and removed request for
a team
October 21, 2026 11:37
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
error and segment span should share the same traceis flaky in the dev-mode run ofreact-router-7-framework-instrumentation. On recent develop runs it fails on the first attempt and passes on retry, and on #25602 it failed every retry.Root cause: errors are sent right away but streamed spans are buffered and flushed later. The three tests before this one all hit
/performance/error-loader, so the segment span listener picks up a late span from an earlier request. In every failed attempt, the error's trace id matches the span the next attempt receives.The test now waits for the error, then polls the collected segment spans for one in the error's trace. This is the same approach the Remix e2e apps use.
🤖 Generated with Claude Code