Repository navigation
Conversation
mydea
added this pull request to stack #25405
October 15, 2026 12:55
mydea
marked this pull request as ready for review
October 15, 2026 14:09
mydea
force-pushed
the
test/e2e-remove-event-dumps
branch
from
October 15, 2026 14:28
01457db to
6be814b
Compare
mydea
force-pushed
the
test/e2e-remove-event-dumps
branch
from
October 16, 2026 07:35
6be814b to
7d04f91
Compare
mydea
force-pushed
the
test/e2e-remove-event-dumps
branch
from
October 16, 2026 08:52
7d04f91 to
46de751
Compare
The Next.js apps dumped all envelopes to `event-dumps/`, which CI uploaded on failure after normalizing transactions into span trees. The normalization has not found any dumps since E2E apps moved to a temp directory, and it doesn't understand streamed spans. Nobody relies on the dumps, so drop the feature. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
force-pushed
the
test/e2e-remove-event-dumps
branch
from
October 16, 2026 09:16
46de751 to
daeed14
Compare
andreiborza
approved these changes
Oct 16, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the
envelopeDumpPathoption of the event proxy, its use in the Next.js andcloudflare-thinkapps, the CI steps that uploaded the dumps on failure, andscripts/normalize-e2e-test-dump-transaction-events.js.Dumps were added in #13998 to compare transaction span trees across Next.js versions. Nobody uses them: the normalization step has matched no files since E2E apps started running in a temp directory (#16783), and nobody noticed. It also only reads
transactionenvelopes, so it can't handle span streaming, which is now the default.Stacked on #25403. Replaces #25393, which GitHub closed as merged by accident during a restack. Its review history is still there.
🤖 Generated with Claude Code