Skip to content

ci: Fail when a Playwright version drifts from the pinned one - #25383

Draft
mydea wants to merge 1 commit into
test/e2e-remove-event-dumpsfrom
ci/check-playwright-versions
Draft

mydea wants to merge 1 commit into
test/e2e-remove-event-dumpsfrom
ci/check-playwright-versions

Conversation

@mydea

@mydea mydea commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Adds a check that every package.json declares the same exact Playwright version (@playwright/test, playwright or playwright-core) as @sentry-internal/test-utils. That covers the root, packages/*, dev-packages/* and every E2E app. It runs in the Lint job's parallel group, so a drifting app fails fast instead of silently testing against different browsers.

@sentry-internal/test-utils is the reference because E2E apps already depend on it for their Playwright config. The script needs no installed dependencies, so it lives in scripts/ and runs with plain node.

Based on #25404, outside the PR stack.

🤖 Generated with Claude Code

@mydea
mydea added this pull request to stack #25385 October 15, 2026 07:44
@mydea
mydea force-pushed the ci/check-playwright-versions branch from 959a597 to e179217 Compare October 15, 2026 11:35
@mydea
mydea removed this pull request from stack #25385 October 15, 2026 11:37
@mydea
mydea added this pull request to stack #25392 October 15, 2026 11:37
@mydea
mydea force-pushed the ci/check-playwright-versions branch from e179217 to a9f3ac0 Compare October 15, 2026 11:58
@mydea
mydea removed this pull request from stack #25392 October 15, 2026 11:58
@mydea
mydea added this pull request to stack #25397 October 15, 2026 11:58
@mydea
mydea force-pushed the ci/check-playwright-versions branch from a9f3ac0 to 92a55bf Compare October 15, 2026 12:51
@mydea
mydea removed this pull request from stack #25397 October 15, 2026 12:51
@mydea
mydea added this pull request to stack #25401 October 15, 2026 12:52
@mydea
mydea removed this pull request from stack #25401 October 15, 2026 12:55
@mydea
mydea changed the base branch from chore/bump-playwright-1.64 to test/e2e-remove-event-dumps October 15, 2026 12:55
@mydea
mydea added this pull request to stack #25405 October 15, 2026 12:56
@mydea
mydea force-pushed the ci/check-playwright-versions branch from 92a55bf to f52aeb7 Compare October 15, 2026 14:28
@mydea
mydea force-pushed the ci/check-playwright-versions branch from f52aeb7 to 9a87a66 Compare October 16, 2026 07:35
@mydea
mydea force-pushed the ci/check-playwright-versions branch from 9a87a66 to 1cdd682 Compare October 16, 2026 08:52
All packages and E2E apps must declare the exact `@playwright/test` version of
`@sentry-internal/test-utils`. The check runs in the Lint job.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mydea
mydea force-pushed the ci/check-playwright-versions branch from 1cdd682 to 2280417 Compare October 16, 2026 09:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant