Skip to content

ci: Install Playwright in the background in more places - #25384

Draft
mydea wants to merge 1 commit into
ci/check-playwright-versionsfrom
ci/playwright-background-installs
Draft

mydea wants to merge 1 commit into
ci/check-playwright-versionsfrom
ci/playwright-background-installs

Conversation

@mydea

@mydea mydea commented Oct 15, 2026 •

Copy link
Copy Markdown
Member

Playwright setup takes about 30s in every browser integration, loader and E2E job. In E2E jobs, the existing background install still makes the job wait a median 14s after the app build, which adds up to about 47 runner-minutes per run.

  • Split install: the apt install-deps (about 18s) and the browser-cache restore (about 15s) don't depend on each other. A new part input lets the workflow run them as two parallel background steps. background: isn't documented for composite actions, so the split happens in the workflow rather than inside the action. When the cache misses, the browsers part uses its own npm cache, so its npx doesn't race the one installing the system deps.
  • Browser integration and loader tests: these now install Playwright while the root node_modules cache restores, instead of afterwards. Background steps must not start next to download-artifact, so restore-cache gets an input to skip its build-output download. The jobs download it before starting the installs.
  • E2E: the install now starts right after the artifact downloads, before Install pnpm, Set up Node and the Bun/Deno/SAM setup. Since ci: Read the Playwright version from package.json in install-playwright #25380 it only needs the app's package.json, not any installed dependencies.

Based on #25383, outside the PR stack.

🤖 Generated with Claude Code

@mydea
mydea added this pull request to stack #25385 October 15, 2026 07:44
@mydea
mydea force-pushed the ci/playwright-background-installs branch from fbff338 to 3db934a Compare October 15, 2026 11:36
@mydea
mydea removed this pull request from stack #25385 October 15, 2026 11:37
@mydea
mydea added this pull request to stack #25392 October 15, 2026 11:37

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 3db934a. Configure here.

Comment thread .github/workflows/build.yml
@mydea
mydea force-pushed the ci/playwright-background-installs branch from 3db934a to 0f7f0c2 Compare October 15, 2026 11:58
@mydea
mydea removed this pull request from stack #25392 October 15, 2026 11:58
@mydea
mydea added this pull request to stack #25397 October 15, 2026 11:58
@mydea
mydea force-pushed the ci/playwright-background-installs branch from 0f7f0c2 to c7d2498 Compare October 15, 2026 12:51
@mydea
mydea removed this pull request from stack #25397 October 15, 2026 12:51
@mydea
mydea added this pull request to stack #25401 October 15, 2026 12:52
@mydea
mydea removed this pull request from stack #25401 October 15, 2026 12:55
@mydea
mydea added this pull request to stack #25405 October 15, 2026 12:56
@mydea
mydea force-pushed the ci/playwright-background-installs branch 2 times, most recently from 963293b to 7eb95ee Compare October 16, 2026 07:35
@mydea
mydea force-pushed the ci/playwright-background-installs branch from 7eb95ee to ba0a952 Compare October 16, 2026 08:52
The install-playwright action gets a `part` input, so the system dependencies
and the browsers can install as two parallel background steps. Browser
integration and loader tests now install Playwright while the dependency cache
restores, and E2E jobs start the install right after the artifact downloads,
before setting up pnpm, Node and other runtimes.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mydea
mydea force-pushed the ci/playwright-background-installs branch from ba0a952 to 5577460 Compare October 16, 2026 09:16

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant