Skip to content

test(browser): Use blocking scripts in loader integration tests #25395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Oct 15, 2026
Merged

test(browser): Use blocking scripts in loader integration tests #25395

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dev-packages/browser-integration-tests/utils/generatePage.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { mkdirSync } from 'fs';
import HtmlWebpackPlugin from 'html-webpack-plugin';
import webpack from 'webpack';
import webpackConfig from '../webpack.config';
import SentryScenarioGenerationPlugin from './generatePlugin';
import SentryScenarioGenerationPlugin, { useLoader } from './generatePlugin';

export async function generatePage(
initPath: string,
Expand Down Expand Up @@ -30,6 +30,9 @@ export async function generatePage(
filename: outPageName,
template: templatePath,
inject: 'body',
// Deferred scripts may run after the loader has swapped in the CDN bundle but before it calls
// `init()`, so their SDK calls would be dropped. Blocking scripts always hit the loader stub.
scriptLoading: useLoader ? 'blocking' : 'defer',
}),
],
}),
Expand Down
2 changes: 1 addition & 1 deletion dev-packages/browser-integration-tests/utils/generatePlugin.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ const useCompiledModule = bundleKey === 'esm' || bundleKey === 'cjs';

// Bundles need to be injected into HTML before Sentry initialization.
const useBundleOrLoader = bundleKey && !useCompiledModule;
const useLoader = bundleKey.startsWith('loader');
export const useLoader = bundleKey.startsWith('loader');

// These are imports that, when using CDN bundles, are not included in the main CDN bundle.
// In this case, if we encounter this import, we want to add this CDN bundle file instead
Expand Down
Loading