Repository navigation
test(browser): Use blocking scripts in loader integration tests - #25395
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 15, 2026 12:17
mydea
requested review from
logaretm and
msonnb
and removed request for
a team
October 15, 2026 12:17
msonnb
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loader tests were flaky (e.g.
sentryOnLoad callback is called before Sentry.onLoad()timing out waiting for the error event).HtmlWebpackPlugin defaults to
deferfor the test'sinit/subjectscripts. With a non-lazy loader, the CDN bundle can load and replace thewindow.Sentrystub before a deferred script runs, while the loader only callsinit()in a latersetTimeout. SDK calls landing in that gap hit the real SDK with no client and are dropped.For loader builds the scripts are now blocking, so they run during parsing right after
loader.jsand always go through the stub's queue — which also mirrors how the loader snippet is used in practice. Non-loader builds keepdefer.🤖 Generated with Claude Code