Skip to content

test(replay): Fix flaky bufferStalledRequests segmentId assertion #25394

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mydea merged 1 commit into from
Oct 15, 2026
Merged

test(replay): Fix flaky bufferStalledRequests segmentId assertion #25394

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion dev-packages/browser-integration-tests/suites/replay/bufferStalledRequests/test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,11 @@ import { expect } from '@playwright/test';
import { sentryTest } from '../../../utils/fixtures';
import { envelopeRequestParser, waitForErrorRequest } from '../../../utils/helpers';
import {
getReplayEvent,
getReplaySnapshot,
isReplayEvent,
shouldSkipReplayTest,
waitForReplayRequest,
waitForReplayRunning,
} from '../../../utils/replayHelpers';

Expand Down Expand Up @@ -155,16 +157,22 @@ sentryTest('buffer mode remains after interrupting replay flush', async ({ getLo
expect(firstSession.session?.dirty).toBe(true);
expect(firstSession.recordingMode).toBe('buffer'); // But still in buffer mode

// The resumed session flushes shortly after reload, which bumps `segmentId` again, so a snapshot
// can't reliably observe `segmentId: 1`. Assert on the first segment sent after reload instead.
const resumedReplayRequestPromise = waitForReplayRequest(page);
await page.reload();
await waitForReplayRunning(page);
const secondSession = await getReplaySnapshot(page);
expect(secondSession.session?.sampled).toBe('buffer');
expect(secondSession.session?.dirty).toBe(true);
expect(secondSession.session?.id).toBe(firstSessionId);
expect(secondSession.session?.segmentId).toBe(1);
// Because a flush attempt was made and not allowed to complete, segmentId increased from 0,
// so we resume in session mode
expect(secondSession.recordingMode).toBe('session');

const resumedReplayEvent = getReplayEvent(await resumedReplayRequestPromise);
expect(resumedReplayEvent.replay_id).toBe(firstSessionId);
expect(resumedReplayEvent.segment_id).toBe(1);
});

sentryTest(
Expand Down
Loading