Repository navigation
test(replay): Fix flaky bufferStalledRequests segmentId assertion - #25394
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
mydea
marked this pull request as ready for review
October 15, 2026 12:32
mydea
requested review from
logaretm and
msonnb
and removed request for
a team
October 15, 2026 12:33
msonnb
approved these changes
Oct 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the reload, the resumed session (now in
sessionmode) flushes segment 1 afterflushMinDelay(200ms), which bumpssegmentIdto 2. Snapshotting replay state could land on either side of that flush, sosegmentIdwas sometimes 2.Instead of snapshotting
segmentId, the test now asserts that the first replay request sent after reload carriessegment_id: 1for the same replay, which verifies the same resumption behavior deterministically.🤖 Generated with Claude Code