Repository navigation
fix(node): restore tsx runtime instrumentation - #25351
Conversation
Fixes getsentry#24787. Signed-off-by: João Pedro de Faria <jpdefo7@hotmail.com> Co-Authored-By: GPT-6.1 Sol <codex@openai.com>
|
Thanks a lot for opening the PR. Before I go deeper on the review could you remove this line to run this specific e2e test again on Node v24? |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
Run the tsx-express E2E application on the inherited Node 24 runtime. Co-Authored-By: GPT-6.1 Sol <codex@openai.com>
|
Removed the tsx-express application's Node 20 override so it inherits Node 24.21.0. All 10 existing tsx-express E2E tests pass on that version with the updated local SDK packages, without changing assertions or timeouts. Also addressed the URL-key issue reported by Bugbot. The duplicate-transform guard now normalizes query/fragment URLs and compares source fingerprints before skipping the compiler transform, preserving the fallback when another loader changes the source. Added query, fragment, and cache-eviction coverage. All eight focused regressions, the full development build, and lint pass. The runtime-injection unit suite has 18 passes and the same two previously reproduced Windows nft tracing failures. |
|
bugbot run |
Under Node >= 24.13 the SDK injects instrumentation via Module.registerHooks, which tsx's CJS loader bypasses. Keep the pin until #25351 lands. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Most e2e apps that pinned their own Node version did so to run on something newer than the old Node 20 base. Since #24343 moved the root to Node 24.21.0, those pins are either redundant or now *older* than the root (e.g. the `24.15.0` pins), so every app now simply extends the root Volta config. This also drops the Node 20 pin that #24343 added to `react-send-to-sentry` as a stopgap, since it passes on Node 24 now. Two overrides remain: - pnpm `11.10.0` in `nuxt-5` and `nuxt-5-sourcemaps`, which was bumped deliberately in #22017. - Node `20.19.5` in `tsx-express`. On Node >= 24.13 the SDK injects instrumentation through `Module.registerHooks`, whose `load` hook tsx's CJS loader bypasses (it replaces `Module._extensions` and calls `_compile` directly), so Express is never instrumented. #25351 fixes this; the pin can go once it lands. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
I think it works overall. I added some comments and once they're addressed we can merge this.
Allow the CommonJS fallback on runtimes with stable synchronous hooks and exercise reloads without closing the client. Co-Authored-By: GPT-6.1 Sol <codex@openai.com>
|
@JPeer264 It's probably ready now, please double check the changes. Thank you! |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 1efa955. Configure here.
JPeer264
left a comment
JPeer264
left a comment
There was a problem hiding this comment.
LGTM. Thanks a lot for fixing that.
3 participants
Restore runtime instrumentation for CommonJS dependencies loaded through tsx on Node 24.13+. Keep synchronous module hooks and use the CommonJS compiler for custom require loaders. Match canonical file URLs and source fingerprints to avoid transforming the same source twice while preserving the fallback for source changed by another loader.
Regression coverage checks native Node and tsx with CommonJS reloads, query and fragment imports, and cache eviction after queried imports. The tsx-express E2E application now inherits Node 24 and all 10 existing tests pass locally. The two existing nft tracing tests fail on Windows with both this patch and the original code.
Fixes #24787