Skip to content

test(e2e): Inherit root Volta config in all e2e test apps - #25369

Merged
mydea merged 2 commits into
developfrom
test/e2e-volta-extend-root
Oct 15, 2026
Merged

mydea merged 2 commits into
developfrom
test/e2e-volta-extend-root

Conversation

@mydea

@mydea mydea commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

Most e2e apps that pinned their own Node version did so to run on something newer than the old Node 20 base. Since #24343 moved the root to Node 24.21.0, those pins are either redundant or now older than the root (e.g. the 24.15.0 pins), so every app now simply extends the root Volta config.

This also drops the Node 20 pin that #24343 added to react-send-to-sentry as a stopgap, since it passes on Node 24 now.

Two overrides remain:

🤖 Generated with Claude Code

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Under Node >= 24.13 the SDK injects instrumentation via Module.registerHooks,
which tsx's CJS loader bypasses. Keep the pin until #25351 lands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mydea
mydea marked this pull request as ready for review October 14, 2026 15:55
@mydea
mydea requested review from JPeer264 and s1gr1d October 14, 2026 15:55

@s1gr1d s1gr1d left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Two notes:

  1. #25334 removes all volta.pnpm pins, including the nuxt-5 ones (because you mentioned the nuxt-5 app in the description)
  2. For future pins, I'd use devEngines.runtime instead of using Volta here: pnpm 12 downloads that Node version itself, and setup-node also looks at this field

@JPeer264 JPeer264 left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm I thought I caught all when I upgraded to Node v24 - seems I was wrong

Edit: Actually I kept tests which had v22 set, to test that version specifically. Dropping it is also fine

@mydea

mydea commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Nice! Two notes:

  1. For future pins, I'd use devEngines.runtime instead of using Volta here: pnpm 12 downloads that Node version itself, and setup-node also looks at this field

can we inherit this too? This is actually IMHO a very useful feature of volta, that we can keep this in sync for these e2e tests without duplicating it everywhere (as basically this PR shows exactly how easy it is to mess this up/misalign this when done manually 😅)

@mydea

mydea commented Oct 15, 2026

Copy link
Copy Markdown
Member Author

Actually I kept tests which had v22 set, to test that version specifically. Dropping it is also fine

My understanding after reviewing those cases was mostly that those needed a newer version than 20, which is why we pinned it, not that we wanted to test 22 specifically!

@mydea
mydea merged commit 71f1ef9 into develop Oct 15, 2026
685 of 686 checks passed
@mydea
mydea deleted the test/e2e-volta-extend-root branch October 15, 2026 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants