Repository navigation
[#6] One routing bullet, sized discoveries, read the guide first - #44
Merged
Merged
Conversation
…; read the guide first Replace the workflow rule's five route bullets with one that sends a session to the skill descriptions, keeping the guards and adding the merged-spec record rule. A discovery outside the work is stated with its size and the author chooses between the branch and an issue, in the code-changes rule, the handback template and implement-spec. The code-changes rule reads the repository's README and contributing guide first. start-task's description stands on its own and its route statement precedes the fit question. Six eval cases prove the behaviours; the fixture setup lets a case overlay a fixture file. Docs stop counting things. Version 0.12.0. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #6
Closes #7
Closes #15
The workflow rule carried a bullet per skill that restated the skill's trigger and narrated what it did, and those sentences went stale when a skill changed: the pull request bullet still said the pr skill drafts "to the team template" after the skill learned to prefer the repository's own. Rules should say "if you're doing this, start here" and otherwise not duplicate what the skills already say; skills exist for uses, check them, and only then default to answering. Measured, the rules are valuable in some cases, where a session is tempted to shortcut, and the branch leans on that. Alongside: a merged spec is a record, a discovery outside the work is stated with its size and the author chooses between keeping it in the branch and filing an issue, and every session reads the repository's own guide before changing code.
What
The workflow rule has one routing bullet, pointing at the skill descriptions with the four guards folded in, plus the standing rules, including that a merged spec is a closed record. A discovery found during work lands in the hand-back's Problems with a size and two options, and implement-spec acts on the author's answer. The code-changes rule reads the README and contributing guide before the code, start-task's description and fit question stand on their own, and six eval cases prove each of these.
Changes
rules/workflow.md: one bullet says to check the skill descriptions first and run the skill that fits, carrying the guards (no baregh pr create, no code before bugfix has reproduced the bug, no spec task skipped or merged, no sizing a change yourself); the small-change exception stays; a yes to a skill's offer counts as the author asking; a merged spec is a record, not work in hand, not edited, not read for current behaviour. Rules should say where to start and not duplicate the skills; the no-rule run shows the descriptions route the plain cases on their own and the rule catches the shortcuts, so the branch leans on the rule where it is valuable.tasks.mdproposal or a drafted issue, never listing it again. Sending every discovery to an issue is a trade-off, not a rule; the agent states it and its likely size, and the author chooses. Executors report underunsureand do not size; the reviewer and the session assess, since executors focus on execution and findings.evals/fixtures/setup.shcopies a fixture file only where the workspace has none, so a case'sfiles/overlay wins and lands in the one commit, and the evals README says so; the Makefile's workflow rule target runs scaffolds; the no-new-dependency prompt says the change is already decided, since the workflow rule was routing it to start-task before the rule it grades could be exercised.closed-spec-is-a-record,reads-contributing-guide,follows-repo-template,offers-commit-on-dirty-tree,offers-choice-on-discovery, andnames-task-and-asksmoved onto the calc fixture so it tests the spec route it describes, withwrong-repo-asks-fitgaining the task-name grader..claude/specs/workflow-rule-wording/, the record of the work, closed on merge.Testing
make validatepasses: 19 checks and both plugin validations; the hook prints 7,967 of 10,000 characters.Evals, default three runs per case, with-plugin scores; baselines were taken before any edit.
Rule targets with the no-plugin arm, after the edits:
The workflow table matches the baseline exactly; no-new-dependency was 0.50 with the plugin at baseline. Without the plugin, every run of reads-contributing-guide added the function and none added the README row the guide asks for.
Skill targets after the edits and after rebasing onto #32 and #42:
Before the rebase, works-all-waves missed one run in three with the turn ending on wave 0's report, which #42 fixed, and names-task-and-asks missed one run in three on phrasing because it hit the Fit path in an empty sandbox; both are 1.00 after the fixes above. Two earlier attempts at the wave 3 tables were discarded for API stalls, 300-second timeouts at near-zero cost in both arms; the evidence is on #41.
What the skill descriptions route on their own, plugin loaded but
rules/workflow.mdremoved, two runs per case:The descriptions route a feature, a PR and a spec without the rule; the rule's guards and the record rule are what hold on the bug and closed-spec cases.
Risk and rollout
Version 0.12.0; teammates pick it up with
claude plugin update freethinking@freethinkingit. The rules and the handback template are loaded into every session and sub-agent by the hooks. The setup-script change affects every scaffolded case; no existing case overlays a fixture file, and the works-one-wave scaffold builds the same file list before and after.Notes for reviewers
🤖 Generated with Claude Code