Repository navigation
[#43] Move the plugin into plugins/freethinking and prepare the listing - #46
Merged
Merged
Conversation
…isting The plugin's manifest, skills, agents, rules, hooks and README move under plugins/freethinking/, with the marketplace file left at the root pointing at that folder, so that Anthropic's plugin directory scans only the plugin and not the eval suite or the spec records. The manifest gains the listing fields and the icon; the hook scripts take the shape the directory's validator follows; the Makefile builds a temporary run tree for every eval target because the runner reads cases only from inside the plugin root; the checks are re-rooted and a listing check is added; the README is split into the plugin's and the repository's. Spec: .claude/specs/directory-listing/. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
# Conflicts: # .claude-plugin/plugin.json # README.md # evals/README.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Closes #43
The developer portal's validation of main on 2026-10-16 returned 8 warnings and 8 policy holds with nothing blocking. Seven holds came from eval scaffolds, the evals README and spec records that an installed plugin never runs; one came from the subagent hook running the session hook. Holds recur on every version, so the test and design material has to leave the folder the directory scans, and the manifest needs the fields a listing shows.
What
The plugin lives in
plugins/freethinking/and the rest of the repository stays outside it, so Anthropic's plugin directory scans only the plugin. The manifest carries the listing fields and the icon, the plugin README ends with a disclosure of what the plugin runs and sends, the hook scripts take the shape the directory's validator follows, and every check and eval target works from the new layout.Changes
plugins/freethinking/and point the marketplace entry at that folder, with both names unchanged. We needed to move the plugin into a plugin dir: it moves the entire plugin and scopes it to plugin code without loading the evals; the moved files contain everything the plugin needs.load-rules.shandload-rules-subagent.shas oneawkprogram each overrules/*.md, with paths written fromCLAUDE_PLUGIN_ROOTonly, no other variable, no command substitution and no script running the other, plus guards for a missing or emptyrules/. The scripts use only the paths the directory's validator can check, so a submission from a subfolder carries no "script not followed" hold; the session output is byte-identical to before.PLUGINvariable,validaterunning the checks and three strict validations, and aRUN_EVALdefine that copies the plugin andevals/into a temporary tree withgit initand the pull request template, runsclaude plugin evalthere and writes results back toevals/results/<timestamp>/, deleting the tree on exit or signal.claude plugin evalreads cases only from inside the plugin root, so the copy is what lets the evals live outside the scanned folder.test_hook_encoder.pyaround fixture rules folders comparing both hook scripts byte for byte, and addtest_listing.pyfor the directory's mechanical rules: README words outside fences, a license, and an icon that is a square PNG of 512 to 2048 px. The listing check guards the icon, which the portal takes only once..claude/specs/directory-listing/, every task ticked, as the record of the design.Testing
make validate: 23 checks OK and all three strict validations pass, on the merged tree with main's PR #44. CI runs the same on this PR.Evals, run by hand on the new layout, one run each:
Each run left its results under
evals/results/at the root and no temporary tree behind. A probe install from a copy of the checkout listed five skills, two agents and two hooks at 0.13.0.Risk and rollout
Existing installs of
freethinking@freethinkingitpick up the new layout on their nextclaude plugin update; the install id is unchanged, so norenamesentry is needed. After merge: validate the repository in the developer portal with plugin pathplugins/freethinking, runclaude plugin update freethinking@freethinkingiton one machine, and record both on #43. The Python 3.9 requirement oftest_listing.pyis confirmed by this PR's CI run.Notes for reviewers
Confirm the plugin folder contains all the expected files and that files outside
plugins/are not needed by the plugin at runtime.load-rules-subagent.shcontains$0as awk's record inside its single-quoted program; strict validation passes, and whether the portal's scanner reads it literally shows only at the post-merge validation. Follow-ups: #45 for a shorter pr walkthrough on spec-built branches.🤖 Generated with Claude Code