Skip to content

Fix renderer timeout hide debounce #417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
forntoh wants to merge 1 commit into from
Closed

Fix renderer timeout hide debounce #417

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/renderer/MenuRenderer.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ MenuRenderer::MenuRenderer(DisplayInterface* display, uint8_t maxCols, uint8_t m
void MenuRenderer::begin() {
display->begin();
startTime = millis();
timeoutTriggered = false;
}

void MenuRenderer::moveCursor(uint8_t cursorCol, uint8_t cursorRow) {
Expand All @@ -15,6 +16,7 @@ void MenuRenderer::moveCursor(uint8_t cursorCol, uint8_t cursorRow) {

void MenuRenderer::restartTimer() {
this->startTime = millis();
timeoutTriggered = false;
display->show();
}

Expand Down
4 changes: 3 additions & 1 deletion src/renderer/MenuRenderer.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ class MenuRenderer {
uint8_t cursorRow;

unsigned long startTime = 0;
bool timeoutTriggered = false;

public:
/**
Expand Down Expand Up @@ -103,9 +104,10 @@ class MenuRenderer {
* @brief Updates the display timer and hides the display if the timeout is reached.
*/
virtual void updateTimer() {
if (millis() - startTime < DISPLAY_TIMEOUT) {
if (timeoutTriggered || millis() - startTime < DISPLAY_TIMEOUT) {
return;
}
timeoutTriggered = true;
LOG(F("MenuRenderer::timeout"));
display->hide();
}
Expand Down
Loading