Skip to content

Fix renderer timeout hide debounce - #417

Closed
forntoh wants to merge 1 commit into
feat/graphical-displayfrom
gd/11-core-lifecycle-context
Closed

forntoh wants to merge 1 commit into
feat/graphical-displayfrom
gd/11-core-lifecycle-context

Conversation

@forntoh

@forntoh forntoh commented May 26, 2026

Copy link
Copy Markdown
Owner

Summary

  • track whether the renderer timeout has already fired in the current timer cycle
  • reset timeout state when the renderer begins or the timer restarts
  • avoid repeated timeout hide/log calls after the display is already hidden

Checks

  • git diff --check
  • pio run -e esp32

Notes

@coderabbitai

coderabbitai Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 275185fd-94db-4708-8797-a20bb58dce97

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch gd/11-core-lifecycle-context

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@forntoh

forntoh commented May 26, 2026

Copy link
Copy Markdown
Owner Author

Closing this tiny timeout-debounce slice because its main benefit is dev-log suppression, which is not valuable enough to carry as a standalone PR. The graphical-display rollout will continue with larger coherent bundles.

@forntoh forntoh closed this May 26, 2026
@forntoh
forntoh deleted the gd/11-core-lifecycle-context branch May 26, 2026 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant