Skip to content

Add Danger Vignette visual effect - #470

Merged
ford442 merged 1 commit into
mainfrom
neon-bricklayer-danger-vignette-8377958866827226259
Aug 4, 2026
Merged

Add Danger Vignette visual effect#470
ford442 merged 1 commit into
mainfrom
neon-bricklayer-danger-vignette-8377958866827226259

Conversation

@ford442

@ford442 ford442 commented Aug 4, 2026

Copy link
Copy Markdown
Owner

Added a 'Danger Vignette' visual effect that pulses red at the screen edges when the board is nearly full.
This enhances the game feel (JUICE) by providing a clear, escalating visual cue of impending danger, while maintaining clarity by only encroaching from the edges.
The implementation ensures consistency across all three post-processing paths (standard, enhanced, and material-aware), and fixes a prior logic error in the standard post-process shader where the vignette was inverted.


PR created automatically by Jules for task 8377958866827226259 started by @ford442

Summary by CodeRabbit

  • New Features

    • Added a red danger vignette effect that intensifies as the board fills.
    • The effect contracts toward the screen center as danger increases.
    • Added a pulsing animation at high danger levels for enhanced visual feedback.
  • Bug Fixes

    • Corrected the danger overlay’s spatial distribution so it appears in the intended screen areas.
  • Documentation

    • Added a journal entry documenting the danger vignette effect.

- Add consistent Danger Vignette logic driven by `uniforms.dangerLevel` to `materialAwarePostProcess.ts` and `enhancedPostProcess.ts`.
- Fix inverted logic in `postProcess.ts` (removed `1.0 -` from `clamp(...)`) so it correctly encroaches from screen edges rather than painting the center.
- The red vignette pulses at 2Hz when the Tetris board is dangerously full (dangerLevel > 0.75).
- Log the new visual juice in `neon_bricklayers_journal.md`.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 4, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 2918d2cd-3dce-4da1-b62b-a1c6310c6ecd

📥 Commits

Reviewing files that changed from the base of the PR and between 4e4ebe0 and fa6863b.

📒 Files selected for processing (4)
  • neon_bricklayers_journal.md
  • src/webgpu/shaders/enhancedPostProcess.ts
  • src/webgpu/shaders/materialAwarePostProcess.ts
  • src/webgpu/shaders/postProcess.ts

📝 Walkthrough

Walkthrough

The shaders now render a danger-level red vignette in enhanced and material-aware post-processing. The effect contracts toward the center, scales with danger, and pulses at 2 Hz above 0.75. The shared radial factor and journal entry were updated.

Changes

Danger vignette

Layer / File(s) Summary
Danger vignette rendering
src/webgpu/shaders/postProcess.ts, src/webgpu/shaders/enhancedPostProcess.ts, src/webgpu/shaders/materialAwarePostProcess.ts, neon_bricklayers_journal.md
The danger vignette radial factor now increases toward the center. Enhanced and material-aware passes add a deep-red overlay that contracts with danger, scales opacity, and pulses at 2 Hz above 0.75. The journal records the behavior.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch neon-bricklayer-danger-vignette-8377958866827226259

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ford442
ford442 marked this pull request as ready for review August 4, 2026 22:08
@ford442
ford442 merged commit c1b0e63 into main Aug 4, 2026
3 checks passed
@ford442
ford442 deleted the neon-bricklayer-danger-vignette-8377958866827226259 branch August 4, 2026 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant