feat: Combo Escalation (Continuous Game Feel) - #469
Conversation
- Exposed `currentCombo` via `GameState` snapshots. - Created `comboEnergy` in `VisualEffects`, mapped to uniform offset 196 (replacing unused `padAudio`). - In the background shader, `comboEnergy` escalates parallax scrolling speed and global ambient pulses. - In the block shader, `comboEnergy` intensifies and accelerates the core neon block breathing pulse. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (9)
📝 WalkthroughWalkthroughChangesThe PR adds combo-driven visual effects. Combo Escalation
Estimated code review effort: 2 (Simple) | ~10 minutes Sequence Diagram(s)sequenceDiagram
participant VisualEffects
participant RenderLoop
participant UniformBuffer
participant BackgroundShader
participant BlockShader
VisualEffects->>RenderLoop: provide comboEnergy
RenderLoop->>UniformBuffer: write background comboEnergy at offset 84
RenderLoop->>UniformBuffer: write block comboEnergy at offset 196
UniformBuffer->>BackgroundShader: supply comboEnergy
UniformBuffer->>BlockShader: supply comboEnergy
Possibly related PRs
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This pull request introduces Combo Escalation to significantly improve the visual game feel during high-combo plays.
Changes:
currentCombois now captured properly in theGameStatesnapshot for view consumption.comboEnergyscalar has been added toVisualEffects. This value continuously updates based on the current combo, with a smooth exponential decay to ensure the energy eases out when the combo breaks.comboEnergyhas been piped through the frame uniform update cycle. It replaces the unusedpadAudiofield at offset 196 inBLOCK_FRAGMENT_UNIFORM_OFFSETS, and_pad1at offset 84 in the background uniform layout.background.ts):comboEnergydynamically increases both the dual-layer perspective grid's scrolling speed and the intensity/speed of the global pulse effect.fragmentMain.wgsl):comboEnergyaccelerates and intensifies the gentle emissive breathing pulse on the neon blocks.Tests:
npm run lint,npm run typecheck, andnpm testlocally.PR created automatically by Jules for task 16555190047794877428 started by @ford442
Summary by CodeRabbit
New Features
Documentation