Skip to content

feat(graphics): add dynamic particle rotation to WGSL shader - #468

Merged
ford442 merged 1 commit into
mainfrom
feat/dynamic-particle-rotation-13551061000570180373
Aug 2, 2026
Merged

feat(graphics): add dynamic particle rotation to WGSL shader#468
ford442 merged 1 commit into
mainfrom
feat/dynamic-particle-rotation-13551061000570180373

Conversation

@ford442

@ford442 ford442 commented Aug 2, 2026

Copy link
Copy Markdown
Owner

Implements dynamic particle rotation in the WebGPU particle shader, allowing particles to spin as they age. This improves the visual 'juice' of the game by making explosive effects (like hard drops and line clears) feel more chaotic and less like static quads stretching along velocity. Logged the enhancement in the Neon Bricklayer's Journal. All tests, linting, and builds pass.


PR created automatically by Jules for task 13551061000570180373 started by @ford442

Summary by CodeRabbit

  • New Features

    • Particle debris now rotates dynamically throughout its lifetime, creating more natural and visually engaging effects.
    • Rotation responds to each particle’s movement and position while preserving velocity-based stretching.
  • Documentation

    • Added a journal entry documenting the updated particle behavior.

- Updated `src/webgpu/shaders/particle.ts` to apply a 2D rotation matrix to particle vertices based on `particleLife` and position.
- Logged the visual update in `neon_bricklayers_journal.md`.
- Enhances game feel by making explosions and debris look more chaotic and impactful.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 8cdd0b74-7aed-4ad4-8560-d7d18a34350f

📥 Commits

Reviewing files that changed from the base of the PR and between 96865e9 and 5a1107d.

📒 Files selected for processing (3)
  • neon_bricklayers_journal.md
  • public/assets/video/manifest.json
  • src/webgpu/shaders/particle.ts

📝 Walkthrough

Walkthrough

The particle vertex shader now applies deterministic rotation based on particle position and lifetime. The journal documents the effect, and the asset manifest timestamp is updated.

Changes

Particle rotation

Layer / File(s) Summary
Shader rotation and generated updates
src/webgpu/shaders/particle.ts, neon_bricklayers_journal.md, public/assets/video/manifest.json
The shader rotates particle quad corners using a position-derived angle, lifetime, and fixed spin rate. The journal records the change. The manifest timestamp is updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch feat/dynamic-particle-rotation-13551061000570180373

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ford442
ford442 marked this pull request as ready for review August 2, 2026 03:55
@ford442
ford442 merged commit d2dc025 into main Aug 2, 2026
3 checks passed
@ford442
ford442 deleted the feat/dynamic-particle-rotation-13551061000570180373 branch August 2, 2026 03:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant