feat(graphics): add dynamic particle rotation to WGSL shader - #468
Conversation
- Updated `src/webgpu/shaders/particle.ts` to apply a 2D rotation matrix to particle vertices based on `particleLife` and position. - Logged the visual update in `neon_bricklayers_journal.md`. - Enhances game feel by making explosions and debris look more chaotic and impactful. Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthroughThe particle vertex shader now applies deterministic rotation based on particle position and lifetime. The journal documents the effect, and the asset manifest timestamp is updated. ChangesParticle rotation
Estimated code review effort: 2 (Simple) | ~10 minutes ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Implements dynamic particle rotation in the WebGPU particle shader, allowing particles to spin as they age. This improves the visual 'juice' of the game by making explosive effects (like hard drops and line clears) feel more chaotic and less like static quads stretching along velocity. Logged the enhancement in the Neon Bricklayer's Journal. All tests, linting, and builds pass.
PR created automatically by Jules for task 13551061000570180373 started by @ford442
Summary by CodeRabbit
New Features
Documentation