Skip to content

feat: cap max global particles to 5000 - #463

Merged
ford442 merged 1 commit into
mainfrom
neon-bricklayer-juice-4186936212885832433
Jul 31, 2026
Merged

feat: cap max global particles to 5000#463
ford442 merged 1 commit into
mainfrom
neon-bricklayer-juice-4186936212885832433

Conversation

@ford442

@ford442 ford442 commented Jul 31, 2026

Copy link
Copy Markdown
Owner

Implemented a strict limit of 5000 on the max global particles to prevent potential lag during explosive visual effects, in line with the "Neon Bricklayer" persona's performance guidelines.


PR created automatically by Jules for task 4186936212885832433 started by @ford442

Summary by CodeRabbit

  • Performance

    • WebGPU particle effects are now capped at 5,000 particles to help maintain performance during heavy effects.
    • Unrecognized or custom quality settings now fall back to a balanced particle budget.
  • Chores

    • Updated asset build metadata.

- Modified `particleBudgetForQuality()` in `src/webgpu/particles/layout.ts` to strictly cap the returned budget at 5000 using `Math.min(budget, 5000)`.
- This ensures that heavy explosive effects do not lag the browser, fulfilling the Neon Bricklayer performance verification clause.
- Added a journal entry to `neon_bricklayers_journal.md` documenting this performance fix.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 31, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ee0c75b-9874-4d41-8555-9c9e0cef9487

📥 Commits

Reviewing files that changed from the base of the PR and between 06c0537 and ed17ebd.

📒 Files selected for processing (3)
  • neon_bricklayers_journal.md
  • public/assets/video/manifest.json
  • src/webgpu/particles/layout.ts

📝 Walkthrough

Walkthrough

The WebGPU particle budget now defaults to the medium budget for unsupported qualities and caps all returned values at 5,000. The journal records this behavior, and the video manifest timestamp is updated.

Changes

Particle budget control

Layer / File(s) Summary
Apply and record the particle budget cap
src/webgpu/particles/layout.ts, neon_bricklayers_journal.md, public/assets/video/manifest.json
particleBudgetForQuality() selects a budget and caps it at 5,000. The journal records the change, and the asset manifest timestamp is updated.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

  • ford442/Tetris_WebGPU#285: Both changes cap WebGPU particle counts at 5,000, but they modify different implementation points.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch neon-bricklayer-juice-4186936212885832433

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ford442
ford442 marked this pull request as ready for review July 31, 2026 11:30
@ford442
ford442 merged commit 47745f5 into main Jul 31, 2026
3 checks passed
@ford442
ford442 deleted the neon-bricklayer-juice-4186936212885832433 branch July 31, 2026 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant