Skip to content

Update exponential decay for shake and bloom effects - #424

Merged
ford442 merged 1 commit into
mainfrom
neon-bricklayer-exponential-decay-7661657725309913315
Jul 16, 2026
Merged

Update exponential decay for shake and bloom effects#424
ford442 merged 1 commit into
mainfrom
neon-bricklayer-exponential-decay-7661657725309913315

Conversation

@ford442

@ford442 ford442 commented Jul 15, 2026

Copy link
Copy Markdown
Owner

Updated the decay formulas for shakeIntensity and neonBloomIntensity in src/webgpu/effects.ts to use true exponential decay (Math.exp) instead of algebraic approximations, resulting in a snappier game feel. Logged the changes in neon_bricklayers_journal.md as requested.


PR created automatically by Jules for task 7661657725309913315 started by @ford442

Summary by CodeRabbit

  • New Features

    • Improved visual effects so screen shake and neon glow fade more naturally and responsively.
  • Chores

    • Updated the video asset build metadata.

Updated the decay formulas for `shakeIntensity` and `neonBloomIntensity` in `src/webgpu/effects.ts` from fast algebraic approximations to true exponential decay using `Math.exp` as required for a snappier game feel. Also logged the updates in `neon_bricklayers_journal.md`.

Co-authored-by: ford442 <9397845+ford442@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@coderabbitai

coderabbitai Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e76d12bb-6b5e-4956-b48e-85e2cb858b50

📥 Commits

Reviewing files that changed from the base of the PR and between 3258264 and c601b51.

📒 Files selected for processing (3)
  • neon_bricklayers_journal.md
  • public/assets/video/manifest.json
  • src/webgpu/effects.ts

📝 Walkthrough

Walkthrough

VisualEffects.updateEffects now uses exponential decay for shake and neon bloom intensities. The visual log records the change, and the video asset manifest receives an updated build timestamp.

Changes

Visual Effect Decay

Layer / File(s) Summary
Exponential effect decay and supporting updates
src/webgpu/effects.ts, neon_bricklayers_journal.md, public/assets/video/manifest.json
shakeIntensity and neonBloomIntensity now decay with Math.exp; the visual log documents the update and the manifest timestamp is refreshed.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Possibly related PRs

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch neon-bricklayer-exponential-decay-7661657725309913315

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ford442
ford442 marked this pull request as ready for review July 16, 2026 06:24
@ford442
ford442 merged commit fca2000 into main Jul 16, 2026
3 checks passed
@ford442
ford442 deleted the neon-bricklayer-exponential-decay-7661657725309913315 branch July 16, 2026 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant