Skip to content

fix(auth): move select imports to internal #16595

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ncooke3 wants to merge 8 commits into from
Closed

fix(auth): move select imports to internal #16595

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
4e185e0
ci(auth): add CocoaPods pod_lib_lint_app_extension test for app exten…
ncooke3 Sep 2, 2026
e47c41f
fix(auth): mark web view presenters unavailable in app extensions
ncooke3 Sep 2, 2026
96212bb
fix(auth): preserve FIRAuthComponent runtime class name for FirebaseC…
ncooke3 Sep 2, 2026
7842ee7
refactor(auth): use internal import for internal SDK and framework de…
ncooke3 Sep 2, 2026
25cd09f
ci(auth): remove unused SPM app extension test job
ncooke3 Sep 2, 2026
2888278
refactor(auth): align internal imports and remove unused test spec
ncooke3 Sep 2, 2026
e43fdfa
ci(auth): remove pod_lib_lint_app_extension workflow job
ncooke3 Sep 2, 2026
8f648bd
refactor(auth): remove unavailable annotations to prevent availabilit…
ncooke3 Sep 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions FirebaseAuth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
# 12.19.0
- [fixed] Fixed a build error in app extensions introduced in 12.18.0, where
`AuthNotificationManager` referenced `UIApplication.shared` directly. (#16583)
- [fixed] Fixed a build error in Objective-C app extensions by using internal
imports for internal framework dependencies. (#16590)
- [fixed] Fixed a persistent crash when interacting with App Check under some
Swift toolchains (like the Flutter SDK) by avoiding a compiler bug in Swift
concurrency thunk generation. (#16549)
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/ActionCode/ActionCodeSettings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseCoreInternal
internal import FirebaseCoreInternal
import Foundation

// TODO(Swift 6 Breaking): Consider breaking up into a checked Sendable Swift
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Auth/Auth.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Foundation
import FirebaseAppCheckInterop
import FirebaseAuthInterop
import FirebaseCore
import FirebaseCoreExtension
internal import FirebaseCoreExtension
#if COCOAPODS
internal import GoogleUtilities
#else
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Auth/AuthComponent.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import Foundation
import FirebaseAppCheckInterop
import FirebaseAuthInterop
import FirebaseCore
import FirebaseCoreExtension
internal import FirebaseCoreExtension

@objc(FIRAuthComponent)
class AuthComponent: NSObject, Library, ComponentLifecycleMaintainer {
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Backend/AuthBackend.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

import FirebaseCore
import FirebaseCoreExtension
internal import FirebaseCoreExtension
import Foundation
#if COCOAPODS
import GTMSessionFetcher
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Backend/AuthBackendRPCIssuer.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

import FirebaseCore
import FirebaseCoreExtension
internal import FirebaseCoreExtension
import Foundation
#if COCOAPODS
@preconcurrency import GTMSessionFetcher
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Backend/AuthRequestConfiguration.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import Foundation

import FirebaseAppCheckInterop
import FirebaseCoreExtension
internal import FirebaseCoreExtension

/// Defines configurations to be added to a request to Firebase Auth's backend.
final class AuthRequestConfiguration {
Expand Down
4 changes: 2 additions & 2 deletions FirebaseAuth/Sources/Swift/Storage/AuthKeychainServices.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,8 +12,8 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseCoreExtension
import FirebaseCoreInternal
internal import FirebaseCoreExtension
internal import FirebaseCoreInternal
import Foundation

/// The prefix string for keychain item account attribute before the key.
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/SystemService/SecureTokenService.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.

import FirebaseCoreInternal
internal import FirebaseCoreInternal
import Foundation

private let kFiveMinutes = 5 * 60.0
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Utilities/AuthLog.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
// limitations under the License.

import FirebaseCore
import FirebaseCoreExtension
internal import FirebaseCoreExtension
import Foundation

enum AuthLog {
Expand Down
4 changes: 2 additions & 2 deletions FirebaseAuth/Sources/Swift/Utilities/AuthURLPresenter.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,9 @@
#if os(iOS)

import Foundation
import SafariServices
internal import SafariServices
import UIKit
import WebKit
internal import WebKit

/// A Class responsible for presenting URL via SFSafariViewController or WKWebView.
class AuthURLPresenter: NSObject,
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAuth/Sources/Swift/Utilities/AuthWebViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@

import Foundation
import UIKit
import WebKit
internal import WebKit

/// Defines a delegate for AuthWebViewController
protocol AuthWebViewControllerDelegate: AnyObject {
Expand Down
Loading