Skip to content

fix(auth): move select imports to internal - #16595

Draft
ncooke3 wants to merge 8 commits into
mainfrom
nc.ci.objc-extension-check
Draft

ncooke3 wants to merge 8 commits into
mainfrom
nc.ci.objc-extension-check

Conversation

@ncooke3

@ncooke3 ncooke3 commented Sep 2, 2026

Copy link
Copy Markdown
Member

One difference FirebaseAuth had was not using internal imports:

nickcooke@nickcooke-mac2 firebase-ios-sdk (main) % git grep "import FirebaseCoreExtension"
FirebaseAI/Sources/AILog.swift:internal import FirebaseCoreExtension
FirebaseAI/Sources/FirebaseAI.swift:internal import FirebaseCoreExtension
FirebaseAI/Tests/Unit/VertexComponentTests.swift:internal import FirebaseCoreExtension
FirebaseAppCheck/Tests/Unit/Swift/AppAttestProviderFactoryTests.swift:internal import FirebaseCoreExtension
FirebaseAppDistributionInternal/Sources/Internal/Logger.swift:internal import FirebaseCoreExtension
🚨 FirebaseAuth/Sources/Swift/Auth/Auth.swift:import FirebaseCoreExtension
🚨 FirebaseAuth/Sources/Swift/Auth/AuthComponent.swift:import FirebaseCoreExtension
🚨 FirebaseAuth/Sources/Swift/Backend/AuthBackend.swift:import FirebaseCoreExtension
🚨 FirebaseAuth/Sources/Swift/Backend/AuthBackendRPCIssuer.swift:import FirebaseCoreExtension
🚨 FirebaseAuth/Sources/Swift/Backend/AuthRequestConfiguration.swift:import FirebaseCoreExtension
🚨 FirebaseAuth/Sources/Swift/Storage/AuthKeychainServices.swift:import FirebaseCoreExtension
🚨  FirebaseAuth/Sources/Swift/Utilities/AuthLog.swift:import FirebaseCoreExtension
FirebaseAuth/Tests/Unit/AuthBackendTests.swift:import FirebaseCoreExtension
FirebaseFunctions/Sources/Functions.swift:internal import FirebaseCoreExtension
FirebaseMLModelDownloader/Sources/DeviceLogger.swift:internal import FirebaseCoreExtension
FirebaseSessions/Sources/FirebaseSessions.swift:internal import FirebaseCoreExtension
FirebaseSessions/Sources/Logger.swift:internal import FirebaseCoreExtension
FirebaseSessions/SourcesObjC/NanoPB/FIRSESNanoPBHelpers.m:@import FirebaseCoreExtension;
FirebaseSessions/Tests/TestApp/Shared/MockSubscriberSDK.swift:internal import FirebaseCoreExtension
FirebaseStorage/Sources/Internal/StorageTokenAuthorizer.swift:internal import FirebaseCoreExtension
FirebaseStorage/Sources/Storage.swift:internal import FirebaseCoreExtension
Firestore/Swift/Source/Codable/DocumentID.swift:internal import FirebaseCoreExtension

@gemini-code-assist

Copy link
Copy Markdown
Contributor
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

@paulb777 paulb777 left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on expected test failure

@ncooke3
ncooke3 force-pushed the nc.ci.objc-extension-check branch from 1b951b7 to 4e185e0 Compare September 2, 2026 22:00
@ncooke3 ncooke3 changed the title ci(auth): add SPM FirebaseAuthExtensionTest job for app extension import fix(auth): move select imports to internal Sep 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants