Repository navigation
fix(vscode): show every namespace as selected when the selection is empty #3521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
rocketstack-matt
merged 3 commits into
finos:main
from
tnalbant:fix/namespace-selection-empty-means-all
Oct 27, 2026
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
e5cd41c
fix(vscode): show every namespace as selected when the selection is e…
tnalbant 2e4bf1b
Merge branch 'main' into fix/namespace-selection-empty-means-all
rocketstack-matt c63ae3f
refactor(vscode): describe the namespace rule without a caller list
tnalbant File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
27 changes: 27 additions & 0 deletions
27
calm-plugins/vscode/src/extension/services/namespace-selection.test.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| import { describe, it, expect } from 'vitest'; | ||
| import { resolveSelectedNamespaces } from './namespace-selection'; | ||
|
|
||
| describe('resolveSelectedNamespaces', () => { | ||
| const available = ['alpha', 'beta', 'gamma']; | ||
|
|
||
| it('treats an empty selection as "all namespaces"', () => { | ||
| expect(resolveSelectedNamespaces(available, [])).toEqual(available); | ||
| }); | ||
|
|
||
| it('treats an unset selection as "all namespaces"', () => { | ||
| expect(resolveSelectedNamespaces(available, undefined)).toEqual(available); | ||
| expect(resolveSelectedNamespaces(available, null)).toEqual(available); | ||
| }); | ||
|
|
||
| it('keeps only the selected namespaces', () => { | ||
| expect(resolveSelectedNamespaces(available, ['gamma', 'alpha'])).toEqual(['alpha', 'gamma']); | ||
| }); | ||
|
|
||
| it('drops names that the hub no longer lists', () => { | ||
| expect(resolveSelectedNamespaces(available, ['alpha', 'gone'])).toEqual(['alpha']); | ||
| }); | ||
|
|
||
| it('returns nothing when the hub lists no namespaces', () => { | ||
| expect(resolveSelectedNamespaces([], [])).toEqual([]); | ||
| }); | ||
| }); |
17 changes: 17 additions & 0 deletions
17
calm-plugins/vscode/src/extension/services/namespace-selection.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,17 @@ | ||
| /** | ||
| * Resolve the `calm.hub.selectedNamespaces` setting against the namespaces the | ||
| * Hub lists. | ||
| * | ||
| * CALM Hub has no namespace selection of its own: the filter is this plugin's | ||
| * setting. VS Code reports an unset string array as `[]`, so `undefined`, `null` | ||
| * and `[]` all mean "every namespace". | ||
| */ | ||
| export function resolveSelectedNamespaces( | ||
| available: readonly string[], | ||
| selection: readonly string[] | null | undefined | ||
| ): string[] { | ||
| if (!selection || selection.length === 0) { | ||
| return [...available]; | ||
| } | ||
| return available.filter((namespace) => selection.includes(namespace)); | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.